Skip to content

Lint fixes for RUF013 and FA100 errors #309

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jul 24, 2025

Conversation

IgorChvyrov-sm
Copy link
Contributor

@IgorChvyrov-sm IgorChvyrov-sm commented Jul 23, 2025

Changes:

Applied fixes for RUF013 and FA100 linter errors:

RUF013 implicit-optional
FA100 future-rewritable-type-annotation

Reason:

Enforcing consistent code style and reducing technical debt.

Copy link

codecov bot commented Jul 23, 2025

Codecov Report

Attention: Patch coverage is 33.55263% with 101 lines in your changes missing coverage. Please review.

Files with missing lines Patch % Lines
...ctor/client/workflow/executor/workflow_executor.py 0.00% 11 Missing ⚠️
src/conductor/client/workflow/task/task.py 26.66% 11 Missing ⚠️
...ductor/client/workflow/task/kafka_publish_input.py 70.37% 8 Missing ⚠️
...rc/conductor/client/workflow/conductor_workflow.py 0.00% 5 Missing ⚠️
...lient/workflow/task/llm_tasks/llm_chat_complete.py 0.00% 5 Missing ⚠️
src/conductor/client/workflow/task/http_task.py 0.00% 4 Missing ⚠️
.../conductor/client/workflow/task/javascript_task.py 0.00% 4 Missing ⚠️
...ent/workflow/task/llm_tasks/llm_index_documents.py 0.00% 4 Missing ⚠️
src/conductor/client/ai/integrations.py 0.00% 3 Missing ⚠️
...rc/conductor/client/workflow/task/do_while_task.py 0.00% 3 Missing ⚠️
... and 19 more
Files with missing lines Coverage Δ
src/conductor/client/authorization_client.py 100.00% <100.00%> (ø)
src/conductor/client/automator/task_handler.py 64.47% <100.00%> (+0.23%) ⬆️
src/conductor/client/automator/utils.py 70.93% <100.00%> (+52.10%) ⬆️
...rc/conductor/client/configuration/configuration.py 94.44% <100.00%> (+0.79%) ⬆️
.../client/configuration/settings/metrics_settings.py 100.00% <100.00%> (ø)
src/conductor/client/metadata_client.py 100.00% <100.00%> (ø)
...nductor/client/orkes/orkes_authorization_client.py 100.00% <100.00%> (ø)
...rc/conductor/client/orkes/orkes_metadata_client.py 100.00% <100.00%> (ø)
...c/conductor/client/orkes/orkes_scheduler_client.py 100.00% <100.00%> (ø)
src/conductor/client/orkes/orkes_task_client.py 96.61% <100.00%> (+0.05%) ⬆️
... and 36 more

... and 77 files with indirect coverage changes

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@IgorChvyrov-sm IgorChvyrov-sm merged commit 7159f48 into main Jul 24, 2025
1 of 2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants