Skip to content

fix: respect auto_close on native provider #63

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Aug 4, 2025

Conversation

alvarosevilla95
Copy link
Contributor

@alvarosevilla95 alvarosevilla95 commented Jun 23, 2025

Summary

auto-close did not prevent claude's buffer from being closed after exiting claude when using native provider. This fixes that replicating the behavior of the snacks provider

@ThomasK33
Copy link
Member

Hey @alvarosevilla95, thanks for this PR.

What's the difference between this new close_on_exit and the existing auto_close?

@alvarosevilla95 alvarosevilla95 changed the title feat: add close_on_exit terminal configuration option fix: respect auto_close on native provider Jul 31, 2025
@alvarosevilla95 alvarosevilla95 changed the title fix: respect auto_close on native provider fix: respect auto_close on native provider Jul 31, 2025
@alvarosevilla95
Copy link
Contributor Author

Hey @alvarosevilla95, thanks for this PR.

What's the difference between this new close_on_exit and the existing auto_close?

Ah yeah I was confused because auto_close did not work as I expected with the native provider. But yes I was essentially just replicating that flag instead of just addressing the fact that it did not work as expected on the native provder.

Changed the PR to just ensure auto_close behaves the same way on native as it does on snacks, ie. the claude code window remains open after the command exits and needs a user interaction to be deleted.

@ThomasK33 ThomasK33 added this pull request to the merge queue Aug 4, 2025
Merged via the queue into coder:main with commit ee1f537 Aug 4, 2025
4 checks passed
@ThomasK33
Copy link
Member

Nice, thanks for the PR 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants