Feature: synchronize cgroup id with ebpf program via shared map #531
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
LGTM, except for the linter errors. |
Often, some decoders such as regexp can run repeatedly on the same input and skip them with regexp filter. An common example is matching cgroup path in a chain like so: ``` - name: cgroup - name: regexp regexps: - ^.*(system.slice).*$ ``` Anything that is not in system.slice cgroup will be skipped. When only a small subset of inputs is matched, the overhead of regexp matching can often be noticable. We add a skip cache here to test for input that would produce ErrSkipLabelSet and skip regex matching on them to reduce the work done on regexp matching. The cache size is customizable with the flag `config.skip-cache-size` Signed-off-by: Daniel Dao <dqminh@cloudflare.com>
Cgroup monitor can be shared with other interested parties, i.e. cgroup id synchronisation with bpf programs, so lift it from cgroup decoder to the exporter itself.
In order to prepare for synchronisation of interested cgroup id with bpf programs, this adds a way to subscribe to cgroup change via a channel share with cgroup monitor.
dqminh
force-pushed
the
cgroup_id
branch
2 times, most recently
from
9ebabfc to
f348a0c
Compare
For some usecases, it's useful for ebpf programs to filter their metrics based on cgroups. It's generally hard to ebpf program to be able to filter cgroup at runtime. This make it easier by allowing ebpf exporter to update known interesting cgroup id at runtime via a shared BPF map.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For some usecases, it's useful for ebpf programs to filter their metrics based on cgroups. It's generally hard to ebpf program to be able to filter cgroup at runtime. This make it easier by allowing ebpf exporter to update known interesting cgroup id at runtime via a shared BPF map.
This requires cgroup fanotify support in kernel to work.