Add GHC 9.10.2 support #2983
Open
Add GHC 9.10.2 support #2983
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
GHC may insert coercions making Clash see underlying types. For the
types mentioned in the commit title, this means Clash will see either a
`Natural` or an `Integer`. These types are (for better or for worse)
represented as machine words, potentially truncating any operations. As
a concrete example, take:
top :: Unsinged 68 -> Unsigned 68 -> Vec 1 (Unsigned 64)
top x y = let res = x + y in res `seq` res :> Nil
Translated to core, we get:
λ(x :: Unsigned 68) ->
λ(y :: Unsigned 68) ->
let
nt :: Natural
= +# @68 topEntity2[GlobalId] x[LocalId]
y[LocalId]
in case nt[LocalId] of
_ ->
Cons @(+ 0 1) @(Unsigned 68) @0
(_CO_ @(~# Natural Natural (+ 0 1) (+ 0 1)))
nt[LocalId]
((Λb ->
Nil @0 @b (_CO_ @(~# Natural Natural 0 0)))
@(Unsigned 68))
I.e., the result of `x + y` gets assinged to a binder of type `Natural`,
making the calculation truncate.
|
Great update! I think we still should wait until the plugins run on 9.10.2 though (cf. clash-lang/ghc-typelits-natnormalise#89). It may be worth to reference this as a dependency here. |
|
clash-lang/ghc-typelits-natnormalise#91 Luckily it's just an issue with the testsuite, not the plugin itself, so I feel okay merging this. I've published a fix in the linked PR. |
martijnbastiaan
force-pushed
the
add-9.10.2-support
branch
from
24ab196 to
719f5d0
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Still TODO:
Check copyright notices are up to date in edited files