Skip to content

fix(fe): add error handling and toast notifications for question and reply improvements #118

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Feb 21, 2025

Conversation

cjeongmin
Copy link
Contributor

개요

  • 질문/답변 개선 기능 사용시 3초 이내에 재요청할 경우 에러 처리를 추가했습니다.

이슈

@cjeongmin cjeongmin added Bug Something isn't working Fix labels Feb 21, 2025
@cjeongmin cjeongmin self-assigned this Feb 21, 2025
@Copilot Copilot AI review requested due to automatic review settings February 21, 2025 05:14
Copy link
Contributor

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Copilot reviewed 5 out of 10 changed files in this pull request and generated no comments.

Files not reviewed (5)
  • apps/client/src/features/create-update-question/ui/CreateQuestionModal.tsx: Evaluated as low risk
  • apps/client/src/features/create-update-reply/ui/CreateReplyModal.tsx: Evaluated as low risk
  • apps/client/src/features/create-update-reply/model/useReplyWritingSupport.ts: Evaluated as low risk
  • apps/client/src/features/create-update-question/model/useQuestionWritingSupport.ts: Evaluated as low risk
  • apps/client/src/features/create-update-question/ui/CreateQuestionModalFooter.tsx: Evaluated as low risk
Comments suppressed due to low confidence (1)

apps/client/src/features/create-update-question/api/improve-question.api.ts:24

  • [nitpick] The error message 'Forbidden' is too vague. Consider changing it to something more descriptive, such as 'You do not have permission to perform this action.'
if (onError) onError(new Error('Forbidden'));

Copy link
Contributor

@wlgh1553 wlgh1553 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm! 고생하셨습니다.

Copy link
Collaborator

@shl0501 shl0501 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

고생하셨습니다.
L
G
T
M
!!

@cjeongmin cjeongmin merged commit bebd539 into main Feb 21, 2025
2 checks passed
@cjeongmin cjeongmin deleted the fix(fe)/error branch February 21, 2025 05:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Bug Something isn't working Fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants