Escaping #670
Open
Escaping #670
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
/**/in comments #171The reason I updated the lock file was for some vulnerabilities fixed by
npm audit fix.The reason I updated ava was because its
engineswere not supporting Node 22 which I was using.I added a
snapshotsscript topackage.jsonto update snapshots since this was not a transparent process and required for fixing changed test expectations.The reason I changed the replacement from
* /to*\/rather than making a normalizer rule per this suggestion is because I think the default behavior should be to work as intended in TypeScript; namely, with the proper escaping, TypeScript will interpret the sequence as the termination of a comment block.If you go to this snippet and hover the mouse over the
function a () {}block, you can see the comment is well-formed.