Java V2: migrate v1 sqs example that compares single messaging to batch messaging #7509
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
the
Java-v2
|
Why did you assign this back to me? |
scmacdon
added
On Call Review needed
|
@tkhill-AWS everything looks good but there is a metadata validation failure. Once that's fixed I can merge it. |
|
@rlhagerm - I fixed the metadata validation error, but still see a WRITEME validation error, but I can't reproduce on my fork/branch. There, the WRITEME validation passes. For good measure, I ran the python |
…Consumer.java</emphasis> - Uses automatic batching of messages.' is not a valid string: it must start with an uppercase letter.
beqqrry-aws
force-pushed
the
java_sqs_batch
branch
from
a92a3a6 to
6bb9452
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request migrates the hard-code v1 example that exists in the SQS Developer guide.Since Java V2 also offers the drop-in replacementSqsAsyncBatchManagerfor theSqsAsyncClient, which offers automatic batching, this approach was also highlighted in the example.These code example demonstrate two approaches to working with SQS messages in batches using the Java SDK. This PR combines the code examples from this original PR and this PR. It turned out that the two PRs were worked on concurrently without knowledge of the other. It made sense to combine them into one PR. The other PR can be canceled at this point.
CDD build is here.CDD build is here.
By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.