Skip to content

Fixed an issue where the gear button could not be clicked if the emai… #1195

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 5 commits into
base: main
Choose a base branch
from

Conversation

lastshogun13
Copy link
Contributor

@lastshogun13 lastshogun13 commented Jul 26, 2025

Reorganized drawer footer layout to fix email display issue when email address is long by moving email to the right side and adjusting element positioning.

Key Changes:

  • Moved email display from left to right side of drawer footer
  • Repositioned settings gear icon to leftmost position
  • Moved statistics chart icon to center-left position
  • Changed email font size from text-sm to text-xs for better space efficiency
  • Repositioned grow div to push email to the far right

Impact on existing users:

  • UI improvement: Resolves layout issues when email address is long
  • Non-breaking change: All functionality remains the same, only visual positioning changed
  • Better space utilization: Email no longer causes layout overflow or truncation

Description of Changes

Please explain the changes in detail.
If there is any impact on existing users (compatibility, degradation, breaking changes, etc.), be sure to include it in the explanation.

Checklist

  • Modified relevant documentation
  • Verified operation in local environment
  • Executed npm run cdk:test and if there are snapshot differences, execute npm run cdk:test:update-snapshot to update snapshots

Related Issues

Please list related issues as much as possible.

before

before

after

fixed

@tbrand
Copy link
Contributor

tbrand commented Jul 28, 2025

How about truncate the email if it exceeds the width? Like bbbbbbbbbbbbbbb@aaaaaaaa.com to bbbbbbbbbbbbbb...

@lastshogun13
Copy link
Contributor Author

Modify the program to truncate at 23 bytes
fixed2

@tbrand
Copy link
Contributor

tbrand commented Jul 29, 2025

Could revert the position of icons?

@lastshogun13
Copy link
Contributor Author

reverted icon position
fix3

@tbrand
Copy link
Contributor

tbrand commented Aug 1, 2025

Could you use truncate class in tailwind?
https://tailwindcss.com/docs/text-overflow

@lastshogun13
Copy link
Contributor Author

use truncate class in tailwind
fix4

Copy link
Contributor

@tbrand tbrand left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!!! Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants