-
Notifications
You must be signed in to change notification settings - Fork 303
feat: agentcore initial implementation #1191
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
maekawataiki
wants to merge
13
commits into
v5
Choose a base branch
from
feat/agentcore
base: v5
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tbrand
reviewed
Aug 4, 2025
|
||
With `agentCoreExternalRuntimes`, you can use externally created AgentCore Runtimes. | ||
|
||
**[parameter.ts](/packages/cdk/parameter.ts) を編集** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
「を編集」が日本語です
}; | ||
``` | ||
|
||
**[packages/cdk/cdk.json](/packages/cdk/cdk.json) を編集** |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
こちらも日本語が入っている
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of Changes
This PR adds some of the AgentCore features.
Design Considerations
AgentCore is in preview and GenU implementation is experimental and subject to change. There may be breaking changes in the future.
The implementation is based on CDK Custom Resource while CloudFormation and CDK is supported for AgentCore. Breaking changes may occur when migrating.
Feature Implemented
AgentCore Runtime:
Default Generic Agent: Implemented with default generic Strands AgentCore Runtime execution environment.
External Agent: Capability to register external AgentCore Runtime. You may bring your own agents / sample agents from the repository. Input and Output format is expected to be compatible with Strands SDK. (See type definition: packages/types/src/agent-core.d.ts)
Current limitation: Only text input is supported. File support is planned.
AgentCore Identity: IAM Authentication (Cognito ID Pool)
AgentCore Observability: Implemented. (CloudWatch Transactional Search should be enabled separately. See doc)
AgentCore Tools Code Interpreter: Implemented with Strands tools.
Future Work
AgentCore Gateway: Not implemented. Gateway may be implemented in future.
AgentCore Memory: Not implemented. Traditional DynamoDB based persistent memory is used. Long Term memory may be implemented in future.
AgentCore Tools: Partially implemented. Code Interpreter is implemented. Planned to integrate with Browser Use.
Checklist
npm run cdk:test
and if there are snapshot differences, executenpm run cdk:test:update-snapshot
to update snapshotsRelated Issues
#1187