Skip to content

AWS SDK v1.11 Patch Migration #1117

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Jul 24, 2025

Conversation

anahatAWS
Copy link
Contributor

Note: This is a continuation of #1115

Description of Changes

This implementation builds on the foundation established in PR #1115, transforming the structural setup into a fully functional SPI-based solution that will replace our current patching approach. This PR does not change the current ADOT functionality because patches have not been removed.

The next/final PR for v1.11 will remove the patches for aws-sdk-1.11 and have unit tests to ensure correct SPI functionality and behaviour. The final PR will also pass all the contract-tests once patches are removed.

Changes include:

  • Migration of patched files into proper package structure:
    NOTE: We are not copying entire files from upstream. Instead, we only migrated the new components that were added by our patches and the methods that use these AWS-specific components. I deliberately removed any code that was untouched by our patches to avoid duplicating upstream instrumentation code. This selective migration ensures we maintain only our AWS-specific additions while letting OTel handle its base functionality.

These added files:

  • Access and modify span attributes
  • Provide consistent formatting tools for span attributes
  • Can be updated at our convenience if needed

Testing

  • Existing functionality verified
  • Contract tests passing
  • Build successful

Related

By submitting this pull request, I confirm that my contribution is made under the terms of the Apache 2.0 license.

@anahatAWS anahatAWS requested a review from a team as a code owner July 18, 2025 19:01
pxaws
pxaws previously approved these changes Jul 23, 2025
@thpierce thpierce merged commit 8a3b772 into aws-observability:main Jul 24, 2025
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants