feat(zitadel) use more secure PKCE flow #438
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
commit: |
|
By looking at https://oauth.net/2/pkce/ it seems that client secret is still recommend and PKCE is not replacing client secret, could you please add it back or justify why we can remove it @julien1619 ? |
|
Ok I will add it back but as an optionnal value because in Zitadel if you choose PKCE you won't have any secret generated. Here is the related issue in Zitadel: zitadel/zitadel#7110 |
|
Please mention me when ready @julien1619 |
remove clientSecret, useless with PKCE add clientSecret as an optional fix
|
@atinux It seems Ok for me now. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the PKCE flow to the Zitadel provider as it's recommended by the provider, inspired by what was done in
azureb2cprovider.