-
-
Notifications
You must be signed in to change notification settings - Fork 243
feat: refactor CLI to be service based and initial migration of server-api #1825
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Conversation
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
🦋 Changeset detectedLatest commit: c27d6a2 The changes in this PR will be included in the next version bump. This PR includes changesets to release 1 package
Not sure what this means? Click here to learn what changesets are. Click here if you're a maintainer who wants to add another changeset to this PR |
Changeset has been generated for this PR as part of auto-changeset workflow.Please review the changeset before merging the PR.
If you are a maintainer or the author of the PR, you can change the changeset by clicking here Tip If you don't want auto-changeset to run on this PR, you can add the label |
Signed-off-by: Ashish Padhy <ashishpadhy1729@gmail.com>
Signed-off-by: Ashish Padhy <ashishpadhy1729@gmail.com>
asyncapi = `${asyncapi}+${proxyUrl}`; | ||
} | ||
const asyncapiInput = (await load(asyncapi)) || (await load()); | ||
|
||
this.specFile = asyncapiInput; | ||
this.metricsMetadata.template = template; | ||
|
||
const watchTemplate = flags['watch']; | ||
const genOption: any = {}; |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
} | ||
|
||
private disableHooksParser(inputs?: string[]) { |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
if (!isURL.test(input.toLowerCase())) { | ||
throw new Error( | ||
'Invalid --registry-url flag. The param requires a valid http/https url.', |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
} catch (err: any) { | ||
// intentional | ||
} |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
let optimizer: Optimizer; | ||
let report: Report; | ||
try { | ||
optimizer = new Optimizer(this.specFile.text()); | ||
report = await optimizer.getReport(); | ||
} catch (err) { | ||
this.error( | ||
new ValidationError({ |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
src/adapters/cli/internal/base.ts
Outdated
await (await this.recorder).flush(); | ||
} catch (e: any) { | ||
if (e instanceof Error) { |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
} catch (e) { | ||
// We did our best... | ||
} |
Check notice
Code scanning / SonarCloud
Exceptions should not be ignored Low
Signed-off-by: Ashish Padhy <ashishpadhy1729@gmail.com>
Signed-off-by: Shurtu-gal <ashishpadhy1729@gmail.com>
Signed-off-by: Ashish Padhy <ashishpadhy1729@gmail.com>
Signed-off-by: Ashish Padhy <ashishpadhy1729@gmail.com>
|
@asyncapi/bounty_team |
Description
start api
command which is working perfectly fine, hence can still be used till I make another PR regarding its release process etc.Related issue(s)
Fixes #1793
Partial #1794