-
Notifications
You must be signed in to change notification settings - Fork 7
Fix: get /apps/:id/bricks must return the same response as /apps/:id/bricks/:id
#167
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
+59
−52
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
/apps/:id/bricks must reutns the compatiable modeld and the model selected/apps/:id/bricks must retuns the same response of /apps/:id/bricks/:id
lucarin91
reviewed
Dec 17, 2025
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
lucarin91
reviewed
Dec 17, 2025
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
lucarin91
requested changes
Dec 17, 2025
Co-authored-by: Luca Rinaldi <l.rinaldi@arduino.cc>
lucarin91
requested changes
Dec 17, 2025
/apps/:id/bricks must retuns the same response of /apps/:id/bricks/:id/apps/:id/bricks must return the same response as /apps/:id/bricks/:id
lucarin91
approved these changes
Dec 17, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
The Applab expcts that the
GET /v1/apps/:id/bricksandGET v1/apps/:id/bricks/:idreturn the same JSON response.Current
Change description
Use the same struct for both endpoints.
New response
Additional Notes
Reviewer checklist
main.