chore: rollback service account name when upgrading componentdefinition #9518
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Auto Cherry-pick Instructions |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In #8328, pod's serviceaccount name has been changed to
kb-{cmpdName}so that pods with the same cmpd can share one serviceaccount. However, this leads to a problem that when upgrading a component's cmpd (by changing the.spec.compDeffield in component object), it will trigger a pod restart since serviceaccount has changed.To avoid pod restarting, we can rollback a serviceaccount change if the underlying policyrules do not change.
An alternate solution is to change the serviceaccount name rule back to
kb-{clusterName}-{componentName}. But this way can lead to a pod restart to all existing clusters.