Skip to content

fix(drill-to-detail): drill to detail by axis with label on axis column #34257

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

zaminalishah
Copy link

SUMMARY

When the axis column in a timeseries chart had a label set on the dataset level then the drill to detail by axis value wasnt working. The problem was that we were sending the label to the backend for filtering but the backend expected the column name.

BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF

bandicam.2025-07-21.22-39-54-987.mp4

ADDITIONAL INFORMATION

Copy link

@korbit-ai korbit-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Review by Korbit AI

Korbit automatically attempts to detect when you fix issues in new commits.
Category Issue Status
Documentation Missing explanation for timestamp column handling ▹ view 🧠 Not in standard
Files scanned
File Path Reviewed
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx

Explore our documentation to understand the languages and file types we support and the files we ignore.

Check out our docs on how you can make Korbit work best for you and your team.

Loving Korbit!? Share us on LinkedIn Reddit and X

Comment on lines 191 to +193
xAxis.label === DTTM_ALIAS
? formData.granularitySqla
: xAxis.label,
: formData.xAxis,

This comment was marked as resolved.

Copy link
Contributor

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Congrats on making your first PR and thank you for contributing to Superset! 🎉 ❤️

We hope to see you in our Slack community too! Not signed up? Use our Slack App to self-register.

@rusackas
Copy link
Member

Thanks for the PR! Approving CI to run 🤞

@msyavuz msyavuz added preset:bounty Issues that have been selected by Preset and have a bounty attached. hold:bounty! labels Jul 22, 2025
Copy link
Member

@msyavuz msyavuz left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

You are doing drillDetailBy gender in this case. Also the video showing it works is not reflecting the change since it is a temporal column in x axis. Try with anythin else than a temporal column and you will see it shows everything still.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dashboard:drill-to-detail hold:bounty! plugins preset:bounty Issues that have been selected by Preset and have a bounty attached. size/XS
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Drill to Detail by Axis value does not work if the Axis column has a label
3 participants