-
Notifications
You must be signed in to change notification settings - Fork 15.4k
fix(drill-to-detail): drill to detail by axis with label on axis column #34257
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
fix(drill-to-detail): drill to detail by axis with label on axis column #34257
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
Category | Issue | Status |
---|---|---|
Missing explanation for timestamp column handling ▹ view | 🧠 Not in standard |
Files scanned
File Path | Reviewed |
---|---|
superset-frontend/plugins/plugin-chart-echarts/src/Timeseries/EchartsTimeseries.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
xAxis.label === DTTM_ALIAS | ||
? formData.granularitySqla | ||
: xAxis.label, | ||
: formData.xAxis, |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! Approving CI to run 🤞 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
You are doing drillDetailBy gender in this case. Also the video showing it works is not reflecting the change since it is a temporal column in x axis. Try with anythin else than a temporal column and you will see it shows everything still.
SUMMARY
When the axis column in a timeseries chart had a label set on the dataset level then the drill to detail by axis value wasnt working. The problem was that we were sending the label to the backend for filtering but the backend expected the column name.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
bandicam.2025-07-21.22-39-54-987.mp4
ADDITIONAL INFORMATION