fix(dashboard): adds dependent filter select first value fixes #34137
+156
−0
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ObservabilityTeam
requested review from
sadpandajoe,
geido,
eschutho,
rusackas,
betodealmeida and
mistercrunch
as code owners
dosubot
bot
added
dashboard
![korbit-ai[bot]](https://avatars.githubusercontent.com/in/322216?s=60&v=4){kind=small}
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
 |
Improve cascade filter check comment ▹ view | 🧠 Not in standard |
 |
Parent Filter Value Count Uses Default Instead of Current State ▹ view | 🧠 Not in scope |
 |
Inefficient JSON.stringify in Dependency Array ▹ view | 🧠 Not in scope |
|
Filter state not updating after parent filter changes ▹ view | 🧠 Not in scope |
|
Incomplete data change detection ▹ view | 🧠 Incorrect |
|
Inaccurate Time Range Dependency Counting ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx | ✅ |
| superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Outdated
Show resolved
Hide resolved
...set-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx
Show resolved
Hide resolved
ObservabilityTeam
force-pushed
the
fix/dependent-filter-select-first-fix
branch
from
da85911 to
6e2dba4
Compare
added 4 commits
July 16, 2025 11:02
* adds a fix for correctly selecting first value of a dependent filter * adds a fix for automatically selecting the correct dependent filter value on changing parent filter value * adds dependent filters fix support for time range filter
ObservabilityTeam
force-pushed
the
fix/dependent-filter-select-first-fix
branch
from
af7768f to
16646e8
Compare
added 2 commits
July 16, 2025 13:02
|
Hi @betodealmeida @eschutho — the Could one of you re-trigger the check? Thanks! |
ObservabilityTeam
changed the title
There was a problem hiding this comment.
Review by Korbit AI
Korbit automatically attempts to detect when you fix issues in new commits.
| Category | Issue | Status |
|---|---|---|
|
Incorrect Parent Filter Count Logic ▹ view | 🧠 Not in scope |
 |
Incomplete JSON stringification error handling ▹ view | 🧠 Not in scope |
|
Incomplete Multi-select Value Validation ▹ view | 🧠 Not in standard |
|
Inefficient Data Change Detection ▹ view | 🧠 Incorrect |
Files scanned
| File Path | Reviewed |
|---|---|
| superset-frontend/src/dashboard/components/nativeFilters/FilterBar/FilterControls/FilterValue.tsx | ✅ |
| superset-frontend/src/filters/components/Select/SelectFilterPlugin.tsx | ✅ |
Explore our documentation to understand the languages and file types we support and the files we ignore.
Check out our docs on how you can make Korbit work best for you and your team.
Comment on lines
+379
to
+380
| const stringifySafe = (val: unknown) => | ||
| typeof val === 'bigint' ? val.toString() : val; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+379
to
+385
| const stringifySafe = (val: unknown) => | ||
| typeof val === 'bigint' ? val.toString() : val; | ||
|
|
||
| const hasDataChanged = | ||
| prev?.length !== curr?.length || | ||
| JSON.stringify(prev?.map(row => stringifySafe(row[col]))) !== | ||
| JSON.stringify(curr?.map(row => stringifySafe(row[col]))); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+394
to
+400
| useEffect(() => { | ||
| if ( | ||
| isChangedByUser.current && | ||
| filterState.value && | ||
| data.some(row => row[col] === filterState.value[0]) | ||
| ) | ||
| return; |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Comment on lines
+162
to
+172
| let selectedParentFilterValueCounts = 0; | ||
|
|
||
| filter?.cascadeParentIds?.forEach(pId => { | ||
| if ( | ||
| dataMaskSelected?.[pId]?.extraFormData?.filters || | ||
| dataMaskSelected?.[pId]?.extraFormData?.time_range | ||
| ) { | ||
| selectedParentFilterValueCounts += | ||
| dataMaskSelected?.[pId]?.extraFormData?.filters?.length ?? 1; | ||
| } | ||
| }); |
This comment was marked as resolved.
This comment was marked as resolved.
Sorry, something went wrong.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Commit message:
SUMMARY
These fixes address issues with dependent filters using the "Select first filter value by default" option:
FilterValue.tsx: Prevents child filters from requesting data before their parent values are set. The request is now delayed until all parent filter data is available, ensuring correct first value selection.
SelectFilterPlugin: Ensures the first value is correctly updated when parent filter values change. A post-check hook verifies external data changes and selects the appropriate default.
BEFORE/AFTER SCREENSHOTS OR ANIMATED GIF
BEFORE
AFTER
TESTING INSTRUCTIONS
ADDITIONAL INFORMATION