Stringbuffer cleanup part2 (splitted commits) #1471
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 14 commits
July 8, 2025 05:52
use StringBuilder in method createCompositeDestination instead of basic String concatenation +=
use StringBuilder instead of StringBuffer in loadJmsMessage method
apply best practices in string collation
avoid StringBuffer and use java 11 String#repeat
avoid StringBuffer and use java 11 String#repeat
rewrite some logging to use params instead of concatenation
use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException
remove StringBuffer where no loop is involved since java compiler will optimize better
rewrite some logging to use params instead of concatenation
grigoni
changed the title
added 14 commits
July 9, 2025 23:00
use StringBuilder in method createCompositeDestination instead of basic String concatenation +=
use StringBuilder instead of StringBuffer in loadJmsMessage method
apply best practices in string collation
avoid StringBuffer and use java 11 String#repeat
avoid StringBuffer and use java 11 String#repeat
rewrite some logging to use params instead of concatenation
use StandardCharsets.UTF_8/US_ASCII which is more robust and does not throw UnsupportedEncodingException
remove StringBuffer where no loop is involved since java compiler will optimize better
rewrite some logging to use params instead of concatenation
…er_splitted' into feature/cleanup_part2_stringbuffer_splitted
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
about StringBuffer usage, this PR splits changes per type and module
use StringBuilder instead of StringBuffer: this avoids unnecessary sync
use StringBuilder best practice when concatenating
avoid concatenation in logging
use java.nio.charset.StandardCharsets for getBytes
use isEmpty() instead of ...length() > 0
use "0123456789".repeat(Math.max(0, loopSize)); instead of a loop with a SB
some typos fixing
see https://issues.apache.org/jira/browse/AMQ-9732