Metrics V2 and Dynamic Config

[DomPeliniAerospike]

CLIENT-3407
CLIENT-3408

[AerospikeNate-L]

probably dont know enough about nodejs / ts to give this an exhaustive review, but a few little nits / confusion poinst stuck out

Otherwise if tests pass & examples work, looks good.

[AerospikeNate-L]

assigns only the least significant byte of a 4-byte unsigned int to the uint8_t that intp points to..
should uint32_t be uint8_t here fore type-safety? maybe copy-paste from get_optional_uint32_property that didnt get refactored?

[DomPeliniAerospike]

This is standard practice for the Nodejs Client. The max number is 2^53 in nodejs. We don't size check for performance reasons, so this truncation practice is standard.

The conversion function get_optional_uint16_property uses Nan::To<uint32_t> to convert values as well.
Nan::To<uint32_t> is the smallest value available for this function, but since we are truncating anyways, we can still use the helper function and just truncate the value into a smaller value.

We also only use this value for small integers in non-database operations, so the result of a truncation should be relatively inconsequential.

Happy to talk more about this if you are still concerned.

[AerospikeNate-L]

is AEROSPIKE_METRICS_CONFLICT -19 or -20?

[DomPeliniAerospike]

Will correct this to -20.

[AerospikeNate-L]

is this the max path string length? do we have this documented somewhere?

[DomPeliniAerospike]

	/**
	 * Directory path to write metrics log files for listeners that write logs.
	 *
	 * Default: . (current directory)
	 */
	char report_dir[256];

C Client has it defined. I will document it in typings/index.d.ts.