-
Notifications
You must be signed in to change notification settings - Fork 103
Fix Navbar style #1
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
@jayparmar11 is attempting to deploy a commit to the JS Mastery Pro Team on Vercel. A member of the Team first needs to authorize it. |
WalkthroughThe GSAP animation in the Navbar component was updated to use the correct CSS property for the blur effect, changing Changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
npm error Exit handler never called! ✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
src/components/Navbar.jsx (1)
15-20
: Include WebKit prefix for Safari and fallback color for broader support.The fix from
backgroundFilter
tobackdropFilter
is correct, but WebKit-based browsers (Safari) need-webkit-backdrop-filter
. Also, not all engines support 8-digit hex alpha; usingrgba(…)
improves compatibility.navTween.fromTo('nav', { backgroundColor: 'transparent' }, { - backgroundColor: '#00000050', - backdropFilter: 'blur(10px)', + backgroundColor: 'rgba(0,0,0,0.31)', // broader hex-alpha fallback + WebkitBackdropFilter: 'blur(10px)', // Safari prefix + backdropFilter: 'blur(10px)', // standard duration: 1, ease: 'power1.inOut' });
Summary by CodeRabbit