-
Notifications
You must be signed in to change notification settings - Fork 0
[Feat] 나만의 맛집 코멘트 등록 API 구현 #90
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
Changes from all commits
Commits
Show all changes
14 commits
Select commit
Hold shift + click to select a range
740cfd4
feat: kakao API 의 응답 값에 따른 StoreCategory 반환
leegwichan 9114576
fix: storeCategory 를 Enum 값을 사용하도록 수정
leegwichan 99064c4
refactor: StoryService 의 StoreService 와의 의존성 제거
leegwichan e10d273
feat: 응원 등록 서비스 로직 구현
leegwichan e7b8319
feat: 응원 등록 API 구현
leegwichan 6bcdb0f
fix: 응원 등록 API 수정 및 테스트 작성
leegwichan 853050d
test: RestDocsRequest 추가로 인한 기존 테스트 개선
leegwichan fc94e11
refactor: 사용하지 않는 메서드 제거
leegwichan bd63ae2
refactor(StoreSearchResult): StoreCategory 판단 시, null 안전성 검증
leegwichan fc16c8f
feat(CheerService): 응원 추가 유효성 검사 추가
leegwichan 0b4cc90
refactor(CheerService): 응원 등록 요청 검증 로직 메서드 분리
leegwichan a3b4e85
merge: 응원 등록 요청 검증 로직 메서드 분리
leegwichan 5fcb770
test: 테스트 이미지를 쉽게 쓸 수 있게 도와주는 `ImageUtils` 생성
leegwichan 571a7dd
test: `ImageUtils` 에러 처리 개선
leegwichan File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
8 changes: 8 additions & 0 deletions
8
src/main/java/eatda/controller/store/CheerRegisterRequest.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
package eatda.controller.store; | ||
|
||
public record CheerRegisterRequest( | ||
String storeKakaoId, | ||
String storeName, | ||
String description | ||
) { | ||
} | ||
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,21 @@ | ||
package eatda.controller.store; | ||
|
||
import eatda.domain.store.Cheer; | ||
import eatda.domain.store.Store; | ||
|
||
public record CheerResponse( | ||
long storeId, | ||
long cheerId, | ||
String imageUrl, | ||
String cheerDescription | ||
) { | ||
|
||
public CheerResponse(Cheer cheer, String imageUrl, Store store) { | ||
this( | ||
store.getId(), | ||
cheer.getId(), | ||
imageUrl, | ||
cheer.getDescription() | ||
); | ||
} | ||
} |
4 changes: 3 additions & 1 deletion
4
src/main/java/eatda/controller/story/FilteredSearchResult.java
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,10 +1,12 @@ | ||
package eatda.controller.story; | ||
|
||
import eatda.domain.store.StoreCategory; | ||
|
||
public record FilteredSearchResult( | ||
String kakaoId, | ||
String name, | ||
String roadAddress, | ||
String lotNumberAddress, | ||
String category | ||
StoreCategory category | ||
) { | ||
} |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.