Add libmagic to better process mime_types on Linux #63
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Problem: serving files as application/application-octext-stream is annoying if the file is ASCII text Solution: When serving files on linux, libmagic can analyze the file to determine filetype when mime_guess has failed. Use libmagic to determine if a file is a plaintext file. Signed-off-by: Michael Mullin <masmullin@gmail.com>
masmullin2000
force-pushed
the
libmagic
branch
from
3acc35a to
2be75d0
Compare
|
Please fix CI |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Problem: serving files as application/application-octext-stream
is annoying if the file is ASCII text
Solution:
When serving files on linux, libmagic can analyze the file
to determine filetype when mime_guess has failed. Use libmagic
to determine if a file is a plaintext file.
Signed-off-by: Michael Mullin masmullin@gmail.com