Enhancement/#6336 comparision sort utils logic #6439
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dinishajais
requested review from
DenizAltunkapan,
yanglbme,
vil02 and
alxkm
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Enhancement #6336
I have refactored and replaced all the compareTo with SortUtil functions. The places where equality is checked or where the code uses the values given by the compareTo() , has not been replaced.
Three files have no changes and the reason is mentioned below:
StrandSort : In this java class the methods in which compareTo is used has <T extends Comparable<? super T>> as the return type. Since the SortUtils functions are declared with , which contradicts. Thus SortUtils functions cannot be used here in this class in any method.
FlashSort : same reason as StrandSort
WiggleSort: This class either has equality or it uses the numerical value given by the compareTo().
Thus apart from above three classes all other classes have been refcatored.
The first time I created the pull request two checks were failing because of improper formatting. Opening it gain with proper formatting.
👍 I have read CONTRIBUTING.md.
👍 This pull request is all my own work -- I have not plagiarized it.
👍 All filenames are in PascalCase.
👍 All functions and variable names follow Java naming conventions.
👍 All new algorithms have a URL in their comments that points to Wikipedia or other similar explanations.
👍 All new code is formatted with clang-format -i --style=file path/to/your/file.java