Skip to content

test(svelte-query/createMutation): add 'sleep' in 'mutationFn' and replace 'queryByText' with 'getByText' #9491

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jul 25, 2025
Merged

test(svelte-query/createMutation): add 'sleep' in 'mutationFn' and replace 'queryByText' with 'getByText' #9491

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
445f800
test(svelte-query/createMutation): add 'sleep' in 'mutationFn' and re…
sukvvon Jul 23, 2025
63ed601
Merge branch 'main' into test/svelte-query-createMutation-simplify-qu…
manudeli Jul 25, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion packages/svelte-query/tests/createMutation/OnSuccessExample.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@
import { writable } from 'svelte/store'
import { QueryClient } from '@tanstack/query-core'
import { createMutation, setQueryClientContext } from '../../src/index.js'
import { sleep } from '@tanstack/query-test-utils'

export let onSuccessMock: any
export let onSettledMock: any
Expand All @@ -12,7 +13,7 @@
setQueryClientContext(queryClient)

const mutation = createMutation({
mutationFn: (vars: { count: number }) => Promise.resolve(vars.count),
mutationFn: (vars: { count: number }) => sleep(10).then(() => vars.count),
onSuccess: (data) => {
onSuccessMock(data)
},
Expand Down
8 changes: 3 additions & 5 deletions packages/svelte-query/tests/createMutation/ResetExample.svelte
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,16 +1,14 @@
<script lang="ts">
import { QueryClient } from '@tanstack/query-core'
import { createMutation, setQueryClientContext } from '../../src/index.js'
import { sleep } from '@tanstack/query-test-utils'

const queryClient = new QueryClient()
setQueryClientContext(queryClient)

const mutation = createMutation({
mutationFn: () => {
const err = new Error('Expected mock error')
err.stack = ''
return Promise.reject(err)
},
mutationFn: () =>
sleep(10).then(() => Promise.reject(new Error('Expected mock error'))),
})
</script>

Expand Down
27 changes: 11 additions & 16 deletions packages/svelte-query/tests/createMutation/createMutation.test.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,14 +20,12 @@ describe('createMutation', () => {
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.advanceTimersByTimeAsync(0)
expect(
rendered.queryByText('Error: Expected mock error'),
).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Error: Expected mock error')).toBeInTheDocument()

fireEvent.click(rendered.getByRole('button', { name: /Reset/i }))
await vi.advanceTimersByTimeAsync(0)
expect(rendered.queryByText('Error: undefined')).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Error: undefined')).toBeInTheDocument()
})

test('Able to call `onSuccess` and `onSettled` after each successful mutate', async () => {
Expand All @@ -46,7 +44,7 @@ describe('createMutation', () => {
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.advanceTimersByTimeAsync(0)
await vi.advanceTimersByTimeAsync(11)
expect(rendered.queryByText('Count: 3')).toBeInTheDocument()

expect(onSuccessMock).toHaveBeenCalledTimes(3)
Expand All @@ -67,14 +65,11 @@ describe('createMutation', () => {

const mutationFn = vi.fn<(value: Value) => Promise<Value>>()

mutationFn.mockImplementationOnce(() => {
return Promise.reject(`Expected mock error`)
})
mutationFn.mockImplementationOnce(() =>
sleep(20).then(() => Promise.reject(`Expected mock error`)),
)

mutationFn.mockImplementation(async (value) => {
await sleep(5)
return Promise.resolve(value)
})
mutationFn.mockImplementation((value) => sleep(10).then(() => value))

const rendered = render(FailureExample, {
props: {
Expand All @@ -86,7 +81,7 @@ describe('createMutation', () => {

fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
expect(rendered.getByText('Data: undefined')).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(0)
await vi.advanceTimersByTimeAsync(21)
expect(rendered.getByText('Status: error')).toBeInTheDocument()
expect(rendered.getByText('Failure Count: 1')).toBeInTheDocument()
expect(
Expand All @@ -96,7 +91,7 @@ describe('createMutation', () => {
fireEvent.click(rendered.getByRole('button', { name: /Mutate/i }))
await vi.advanceTimersByTimeAsync(0)
expect(rendered.getByText('Status: pending')).toBeInTheDocument()
await vi.advanceTimersByTimeAsync(6)
await vi.advanceTimersByTimeAsync(11)
expect(rendered.getByText('Status: success')).toBeInTheDocument()
expect(rendered.getByText('Data: 2')).toBeInTheDocument()
expect(rendered.getByText('Failure Count: 0')).toBeInTheDocument()
Expand Down
Loading