Skip to content

ST6RI-874 Features subset each other in Transfers and Flows library models (KERML11-78, SYSML21-324) #682

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 7 commits into from
Aug 1, 2025
Merged

ST6RI-874 Features subset each other in Transfers and Flows library models (KERML11-78, SYSML21-324) #682

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
7 commits
Select commit Hold shift + click to select a range
40fde7a
ST6RI-874 Corrected check for validateConnectorBinarySpecialization.
seidewitz Jul 30, 2025
6096547
SYSML21-324 Removed end features from Message and messages.
seidewitz Jul 30, 2025
214ef7a
ST6RI-874 Corrected example, training and validation models.
seidewitz Jul 30, 2025
ecc7cfd
ST6RI-874 Updated model library index.
seidewitz Jul 30, 2025
3a5b4e9
ST6RI-874 Corrected ElementUtil::transformAll.
seidewitz Jul 30, 2025
6fe9d37
KERML11-78 Made Transfers::transfers and messageTransfers into steps.
seidewitz Jul 31, 2025
96d80ef
SYSML21-324 Used keyword "flow" in flows and successionFlows decls.
seidewitz Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions org.omg.kerml.xpect.tests/library/Transfers.kerml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ standard library package Transfers {
end feature target: Occurrence redefines Transfer::target, TransferBefore::target;
}

abstract flow transfers: Transfer[0..*] nonunique subsets performances, binaryLinks {
abstract step transfers: Transfer[0..*] nonunique subsets performances, binaryLinks {
doc
/*
* transfers is a specialization of performances and binaryLinks restricted to type
Expand All @@ -188,7 +188,7 @@ standard library package Transfers {
end feature target: Occurrence redefines Transfer::target, binaryLinks::target;
}

abstract flow messageTransfers: MessageTransfer[0..*] nonunique subsets transfers {
abstract step messageTransfers: MessageTransfer[0..*] nonunique subsets transfers {
doc
/*
* messageTransfers is a specialization of transfers restricted to type MessageTransfers.
Expand Down
2 changes: 1 addition & 1 deletion org.omg.kerml.xtext/src/org/omg/kerml/xtext/validation/KerMLValidator.xtend
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -957,7 +957,7 @@ class KerMLValidator extends AbstractKerMLValidator {
}

// validateConnectorBinarySpecialization
val connectorEnds = TypeUtil.getAllEndFeaturesOf(c)
val connectorEnds = c.connectorEnd
if (connectorEnds.size() > 2) {
val binaryLinkType = SysMLLibraryUtil.getLibraryElement(c, "Links::BinaryLink") as Type
if (c.conformsTo(binaryLinkType)) {
Expand Down
4 changes: 2 additions & 2 deletions org.omg.sysml.xpect.tests/library.kernel/Transfers.kerml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -177,7 +177,7 @@ standard library package Transfers {
end feature target: Occurrence redefines Transfer::target, TransferBefore::target;
}

abstract flow transfers: Transfer[0..*] nonunique subsets performances, binaryLinks {
abstract step transfers: Transfer[0..*] nonunique subsets performances, binaryLinks {
doc
/*
* transfers is a specialization of performances and binaryLinks restricted to type
Expand All @@ -188,7 +188,7 @@ standard library package Transfers {
end feature target: Occurrence redefines Transfer::target, binaryLinks::target;
}

abstract flow messageTransfers: MessageTransfer[0..*] nonunique subsets transfers {
abstract step messageTransfers: MessageTransfer[0..*] nonunique subsets transfers {
doc
/*
* messageTransfers is a specialization of transfers restricted to type MessageTransfers.
Expand Down
10 changes: 2 additions & 8 deletions org.omg.sysml.xpect.tests/library.systems/Flows.sysml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -42,9 +42,6 @@ standard library package Flows {
* a transfer of objects or values between two occurrences. It is
* the base type of all FlowUsages.
*/

end occurrence source: Occurrence :>> Transfer::source;
end occurrence target: Occurrence :>> Transfer::target;

ref payload :>> MessageAction::payload, Transfer::payload;

Expand Down Expand Up @@ -104,12 +101,9 @@ standard library package Flows {
/*
* messages is the base feature of all FlowUsages.
*/

end occurrence source: Occurrence :>> Message::source, transfers::source;
end occurrence target: Occurrence :>> Message::target, transfers::target;
}

abstract message flows: Flow[0..*] nonunique :> messages, flowTransfers {
abstract flow flows: Flow[0..*] nonunique :> messages, flowTransfers {
doc
/*
* flows is the base feature for FlowUsages that identify their source output
Expand All @@ -120,7 +114,7 @@ standard library package Flows {
end occurrence target: Occurrence :>> Flow::target, messages::target, flowTransfers::target;
}

abstract message successionFlows: SuccessionFlow[0..*] nonunique :> flows, flowTransfersBefore {
abstract flow successionFlows: SuccessionFlow[0..*] nonunique :> flows, flowTransfersBefore {
doc
/*
* successionFlows is the base feature of all SuccessionFlowUsages.
Expand Down
1 change: 1 addition & 0 deletions org.omg.sysml/src/org/omg/sysml/util/ElementUtil.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -354,6 +354,7 @@ public static void transformAll(Element root, boolean addImplicitElements) {
}
}
if (addImplicitElements && root instanceof Type) {
root.setIsImpliedIncluded(true);
TypeUtil.insertImplicitBindingConnectors((Type)root);
TypeUtil.insertImplicitSpecializations((Type)root);
if (root instanceof Feature) {
Expand Down
Loading