Update remote URL parsing to support non-git ssh user
#189
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey Nadock. Thanks for the PR. Looks like a very reasonable feature and implementation. Great that you added a test to verify as well! Will look to get out a new release in the coming days. |
|
A new version has been pushed to Open VSX and Visual Studio Marketplace. |
|
Thanks for merging this @Sertion — I've just checked and the latest version does indeed fix this issue. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
On my work device, all of our GitHub remotes are configured with remote URLs that look like
org-1234567@github.com/Org/repo.git. This is (I believe) part of how enterprise federate access works.As a result, the regex used to match the user section of the remote URL does not match and the URL the generated looks like
https://github.comno-remote-url/commit/{hash}. Note the no-remote-url part.The fix is to update the regex to correctly match these remote URLs. I have included that fix and a test to reproduce the issue in this PR.