Initialize line split fixes following Catalyst.jl PR #1306 #982
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit creates the branch for fixing line splits following Catalyst.jl PR #1306 guidelines. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Fixed 6 instances of unnecessary line splits across multiple files: - src/ffjord.jl: Fixed 2 mathematical expressions (logpz calculation and cat function call) - src/multiple_shooting.jl: Fixed 2 arithmetic expressions with continuity_loss - docs/src/examples/augmented_neural_ode.md: Fixed 2 identical arithmetic expressions in random_point_in_sphere function All changes follow Catalyst.jl PR #1306 guidelines to improve readability by keeping semantically related expressions on single lines while staying under 120 character limits. Related to: JuliaFormatter.jl PR #934 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| @@ -11,8 +11,7 @@ const cdev = cpu_device() | |||
| const gdev = gpu_device() | |||
|
|
|||
| function random_point_in_sphere(dim, min_radius, max_radius) | |||
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ | |||
| min_radius | |||
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ min_radius | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ min_radius | |
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ | |
| min_radius |
| @@ -138,8 +137,7 @@ circle, and `-1` to any point which lies between the inner and outer circle. Our | |||
|
|
|||
| ```@example augneuralode | |||
| function random_point_in_sphere(dim, min_radius, max_radius) | |||
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ | |||
| min_radius | |||
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ min_radius | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ min_radius | |
| distance = (max_radius - min_radius) .* (rand(Float32, 1) .^ (1.0f0 / dim)) .+ | |
| min_radius |
| @@ -118,8 +118,7 @@ function __ffjord(model::StatefulLuxLayer, u::AbstractArray{T, N}, p, ad = nothi | |||
| end | |||
| end | |||
| if regularize | |||
| return cat(mz, -trace_jac, sum(abs2, mz; dims = 1:(N - 1)), | |||
| __norm_batched(eJ); dims = Val(N - 1)) | |||
| return cat(mz, -trace_jac, sum(abs2, mz; dims = 1:(N - 1)), __norm_batched(eJ); dims = Val(N - 1)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| return cat(mz, -trace_jac, sum(abs2, mz; dims = 1:(N - 1)), __norm_batched(eJ); dims = Val(N - 1)) | |
| return cat(mz, -trace_jac, sum(abs2, mz; dims = 1:(N - 1)), | |
| __norm_batched(eJ); dims = Val(N - 1)) |
| @@ -156,8 +155,7 @@ function __forward_ffjord(n::FFJORD, x::AbstractArray{T, N}, ps, st) where {T, N | |||
| end | |||
|
|
|||
| if n.basedist === nothing | |||
| logpz = -sum(abs2, z; dims = 1:(N - 1)) / T(2) .- | |||
| T(prod(S[1:(N - 1)]) / 2 * log(2π)) | |||
| logpz = -sum(abs2, z; dims = 1:(N - 1)) / T(2) .- T(prod(S[1:(N - 1)]) / 2 * log(2π)) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| logpz = -sum(abs2, z; dims = 1:(N - 1)) / T(2) .- T(prod(S[1:(N - 1)]) / 2 * log(2π)) | |
| logpz = -sum(abs2, z; dims = 1:(N - 1)) / T(2) .- | |
| T(prod(S[1:(N - 1)]) / 2 * log(2π)) |
| @@ -69,8 +69,7 @@ function multiple_shoot(p, ode_data, tsteps, prob::ODEProblem, loss_function::F, | |||
| if i > 1 | |||
| # Ensure continuity between last state in previous prediction | |||
| # and current initial condition in ode_data | |||
| loss += continuity_term * | |||
| continuity_loss(group_predictions[i - 1][griddims..., end], u[griddims..., 1]) | |||
| loss += continuity_term * continuity_loss(group_predictions[i - 1][griddims..., end], u[griddims..., 1]) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| loss += continuity_term * continuity_loss(group_predictions[i - 1][griddims..., end], u[griddims..., 1]) | |
| loss += continuity_term * continuity_loss( | |
| group_predictions[i - 1][griddims..., end], u[griddims..., 1]) |
| @@ -170,8 +169,7 @@ function multiple_shoot(p, ode_data, tsteps, ensembleprob::EnsembleProblem, | |||
| if i > 1 | |||
| # Ensure continuity between last state in previous prediction | |||
| # and current initial condition in ode_data | |||
| loss += continuity_term * | |||
| continuity_loss(group_predictions[i - 1][griddims..., end, :], u[griddims..., 1, :]) | |||
| loss += continuity_term * continuity_loss(group_predictions[i - 1][griddims..., end, :], u[griddims..., 1, :]) | |||
There was a problem hiding this comment.
[JuliaFormatter] reported by reviewdog 🐶
Suggested change
| loss += continuity_term * continuity_loss(group_predictions[i - 1][griddims..., end, :], u[griddims..., 1, :]) | |
| loss += continuity_term * continuity_loss( | |
| group_predictions[i - 1][griddims..., end, :], u[griddims..., 1, :]) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Initialize fixing unnecessary line splits following Catalyst.jl PR #1306 guidelines. Part of systematic effort across 10+ SciML repositories. 🤖 Generated with Claude Code