-
Notifications
You must be signed in to change notification settings - Fork 57
589 enhance appointment limits #599
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
589 enhance appointment limits #599
Conversation
…nts-App into 589-enhance-appointment-limits
@DavidCuentasMar , I think we have to count the appointment type limits by instance rather than event. I tried to modify your inner query a bit to account for instance:
I was getting some errors with this approach. Then I wondered if we should just write an AggregatedResults query to count and then apply to a map of appointment types and the count for your comparison method later. Here is a quick example of what I mean.
What do you think? I also added the new fields you created to the admin permission set. Thanks! |
Hi @tcdahlberg you are completely right on counting by instance instead of event. That scenario didn't cross my mind 😅 Thanks! I'm coming back from a long vacation, I'll try get up to speed asap 👍 |
@tcdahlberg New changes applied. I used AggregateResult suggestion 👍 |
Critical Changes
Changes
Issues Closed