Skip to content

Conversation

jolyndenning
Copy link

#1822 removed the vim and emacs keybindings - this adds an option to @inquirer/select to support them again.

Copy link

codecov bot commented Sep 20, 2025

Codecov Report

✅ All modified and coverable lines are covered by tests.
⚠️ Please upload report for BASE (main@3d49561). Learn more about missing BASE report.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1838   +/-   ##
=======================================
  Coverage        ?   95.75%           
=======================================
  Files           ?       45           
  Lines           ?     2783           
  Branches        ?      758           
=======================================
  Hits            ?     2665           
  Misses          ?      109           
  Partials        ?        9           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@SBoudrias
Copy link
Owner

Hey 👋🏻 Thanks for the PR.

Do you feel strongly about having those in Inquirer? It does still conflict with the search functionality in the select prompt.

Personally I'm leaning towards not re-adding the feature at all.

@jolyndenning
Copy link
Author

I am a vim user who tries for home row navigation wherever possible, so I'll probably stay on old version of @inquirer/prompts or use my fork of it, if needed. I was confused and disappointed when a fresh install of a library that uses inquirer broke that behavior for me, due to the dependencies within inquirer being listed with ^ syntax so that the change in behavior happens even without updating the @inquirer/prompts version in package.json.

I don't use the search functionality with the select prompt, and ended up downgrading, pinning, and bundling @inquirer/prompts and its dependencies to be able to continue using the vim bindings. See single-spa/heeler#16 and single-spa/heeler#17

@SBoudrias
Copy link
Owner

I'm open to bringing it back, but this PR will need some extra work:

  1. We should turn off searches if bindings are on
  2. We'll need to cover the checkbox prompt as well

@jolyndenning
Copy link
Author

Updated with your feedback

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants