-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Add optional support for vim and emac bindings #1838
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #1838 +/- ##
=======================================
Coverage ? 95.75%
=======================================
Files ? 45
Lines ? 2783
Branches ? 758
=======================================
Hits ? 2665
Misses ? 109
Partials ? 9 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Hey 👋🏻 Thanks for the PR. Do you feel strongly about having those in Inquirer? It does still conflict with the search functionality in the select prompt. Personally I'm leaning towards not re-adding the feature at all. |
I am a vim user who tries for home row navigation wherever possible, so I'll probably stay on old version of I don't use the search functionality with the select prompt, and ended up downgrading, pinning, and bundling |
I'm open to bringing it back, but this PR will need some extra work:
|
Updated with your feedback |
#1822 removed the vim and emacs keybindings - this adds an option to
@inquirer/select
to support them again.