Migrate project to Bun runtime #5
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was a problem hiding this comment.
Pull Request Overview
This PR migrates the project from Node.js to the Bun runtime by switching clients, drivers, scripts, and documentation.
- Replace ioredis with Bun’s native
RedisClientand adjust connection logic - Swap
@libsql/clientfor Bun’sbun:sqlite, add a lightweight wrapper, and update Drizzle initialization - Update docs, package scripts, and engine definitions for Bun compatibility
Reviewed Changes
Copilot reviewed 7 out of 7 changed files in this pull request and generated 3 comments.
Show a summary per file
| File | Description |
|---|---|
| src/lib/redis.ts | Swapped ioredis for Bun’s RedisClient and refactored event handling |
| src/lib/db/index.ts | Replaced libSQL client with Bun’s SQLite API and wrapper; updated Drizzle import |
| src/content/docs/quickstart.md | Changed runtime prerequisite to Bun 1.2.9+ |
| src/content/docs/configuration.md | Clarified NODE_ENV description |
| src/content/docs/architecture.md | Updated backend runtime references to Bun |
| package.json | Updated engines, scripts (bun/bunx), and removed unused deps |
| README.md | Updated prerequisites and backend runtime to Bun |
Comments suppressed due to low confidence (2)
src/lib/db/index.ts:18
- The new SQLite wrapper’s
executemethod isn’t covered by tests. Adding unit tests for both read and write paths will help catch regressions and ensure correct behavior.
export const client = {
src/lib/db/index.ts:31
- Drizzle is now initialized with the raw Bun SQLite instance instead of the wrapper client. Verify that this meets your parameter substitution and transaction needs—if not, consider passing the wrapper client to Drizzle.
export const db = drizzle(sqlite);
Comment on lines
+11
to
+23
| return new RedisClient(redisUrl, { | ||
| autoReconnect: true, | ||
| }); | ||
| } | ||
|
|
||
| export const redis = new Redis(redisUrl, redisOptions); | ||
| export const redisPublisher = new Redis(redisUrl, redisOptions); // For publishing | ||
| export const redisSubscriber = new Redis(redisUrl, redisOptions); // For subscribing | ||
| export const redis = createClient(); | ||
| export const redisPublisher = createClient(); | ||
| export const redisSubscriber = createClient(); | ||
|
|
||
| // Log connection events | ||
| redis.on('connect', () => console.log('Redis client connected')); | ||
| redis.on('error', (err) => console.error('Redis client error:', err)); | ||
| redis.on('ready', () => console.log('Redis client ready')); | ||
| redis.on('reconnecting', () => console.log('Redis client reconnecting...')); | ||
| redis.onconnect = () => console.log("Connected to Redis server"); | ||
| redis.onclose = (err) => { | ||
| if (err) console.error("Disconnected from Redis server:", err); | ||
| }; |
There was a problem hiding this comment.
Event handlers are only attached to the primary Redis client, not to the publisher or subscriber. Consider registering common connection/error logging inside createClient so all instances receive consistent handling.
Copilot uses AI. Check for mistakes.
|
|
||
| // Simple async wrapper around Bun's SQLite API for compatibility | ||
| export const client = { | ||
| async execute(sql: string, params?: any[]) { |
There was a problem hiding this comment.
Detection of SELECT queries via a simple regex could fail for SQL with leading comments or unusual whitespace. Consider separate read/write methods or a more robust strategy for distinguishing query types.
Copilot uses AI. Check for mistakes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Testing
bun x vitest run