Skip to content
This repository was archived by the owner on Jan 4, 2024. It is now read-only.

[WIP] Better Customization #24

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open
Show file tree
Hide file tree
Changes from all commits
Commits
File filter

Filter by extension

Filter by extension


Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
55 changes: 35 additions & 20 deletions lib/server.js
Original file line number Diff line number Diff line change
Expand Up @@ -47,16 +47,6 @@ var fs = require('fs');
*/
var soap = require('soap');

/**
* An HTTP server that will be used
* to listen for SOAP requests.
*/
var server = http.createServer(function(req, res) {
res.end('404: Not Found: ' + req.url);
});

var port = process.env.QB_SOAP_PORT || 8000;

/**
* A constant for the WSDL filename.
* @type {string}
Expand All @@ -83,18 +73,43 @@ function buildWsdl() {

module.exports = Server;

function Server() {
this.wsdl = buildWsdl();
this.webService = require('./web-service');
function Server(config) {
this.server = http.createServer(function(req, res) {
res.end('404: Not Found: ' + req.url);
});

this.config;
if(!config) {
this.config = {
username: process.env.QB_USERNAME || '',
password: process.env.QB_PASSWORD || '',
company_file: process.env.QB_COMPANY_FILE || '',
soap_port: process.env.QB_SOAP_PORT || 8000
}
} else {
this.config = config;
}

this.wsdl = buildWsdl();
this.webService = null;
this.soapServer = null;
}

Server.prototype.run = function() {
var soapServer;
server.listen(port);
soapServer = soap.listen(server, '/wsdl', this.webService.service, this.wsdl);
console.log('Quickbooks SOAP Server listening on port ' + port);
this.server.listen(this.config.soap_port);
this.soapServer = soap.listen(this.server, '/wsdl', this.webService.service, this.wsdl);
console.log('Quickbooks SOAP Server listening on port ' + this.config.soap_port);
};

Server.prototype.setQBXMLHandler = function(qbXMLHandler) {
this.webService.setQBXMLHandler(qbXMLHandler);
};
Server.prototype.restart = function() {
let _this = this;
_this.server.close(() => {
console.log('Quickbooks SOAP Server closed');
_this.run();
});
}

Server.prototype.setQBXMLHandler = function(qbXMLHandler, config) {
this.webService = require('./web-service');
this.webService.setQBXMLHandler(qbXMLHandler, config);
};
14 changes: 8 additions & 6 deletions lib/web-service.js
Original file line number Diff line number Diff line change
Expand Up @@ -36,9 +36,8 @@ var semver = require('semver');
/**
* A library to generate UUIDs
*
* https://github.com/broofa/node-uuid
*/
var uuid = require('node-uuid');
var uuid = require('uuid/v1');

/**
* A constant for the minimum supported
Expand Down Expand Up @@ -176,7 +175,7 @@ webService.QBWebConnectorSvc.QBWebConnectorSvcSoap.clientVersion = function(args
*/
webService.QBWebConnectorSvc.QBWebConnectorSvcSoap.authenticate = function(args, callback) {
var authReturn = [];
authReturn[0] = uuid.v1();
authReturn[0] = uuid();

if (args.strUserName.trim() === username && args.strPassword.trim() === password) {

Expand Down Expand Up @@ -330,9 +329,12 @@ webService.QBWebConnectorSvc.QBWebConnectorSvcSoap.closeConnection = function(ar
module.exports = {
service: webService,

setQBXMLHandler: function(xmlHandler) {
setQBXMLHandler: function(xmlHandler, config) {
qbXMLHandler = xmlHandler;
if(config) {
username = config.username;
password = config.password;
companyFile = config.company_file;
}
}
};


10 changes: 5 additions & 5 deletions package.json
Original file line number Diff line number Diff line change
@@ -1,7 +1,7 @@
{
"name": "quickbooks-js",
"version": "1.0.0",
"author": "Rappid Development LLC",
"name": "uh-quickbooks-js",
"version": "1.0.3",
"author": "uh-sem-blee",
"description": "A SOAP service implemented in Node.js that communicates with QuickBook's Web Connector",
"repository": {
"type": "git",
Expand All @@ -24,9 +24,9 @@
"license": "MIT",
"dependencies": {
"data2xml": "^1.2.5",
"node-uuid": "1.4.3",
"semver": "^5.3.0",
"soap": "0.9.1"
"soap": "0.9.1",
"uuid": "^3.1.0"
},
"devDependencies": {
"chai": "^3.5.0",
Expand Down
11 changes: 7 additions & 4 deletions test/client/client.js
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,6 @@

// Private
var soap = require('soap');
var url = 'http://localhost:8000/wsdl?wsdl';

// Public
module.exports = Client;
Expand All @@ -23,8 +22,12 @@ module.exports = Client;
* This acts as a mock quickbooks web connector.
* @constructor
*/
function Client() {
this.client = null;
function Client(port) {
this.url = 'http://localhost:8000/wsdl?wsdl';
if(port) {
this.url = `http://localhost:${port}/wsdl?wsdl`;
}
this.client = null;
}

/**
Expand All @@ -33,7 +36,7 @@ function Client() {
*/
Client.prototype.createClient = function(callback) {
var that = this;
soap.createClient(url, function(err, client) {
soap.createClient(this.url, function(err, client) {
if (err) return callback(err);
that.client = client;
return callback(null);
Expand Down
11 changes: 8 additions & 3 deletions test/test.js
Original file line number Diff line number Diff line change
Expand Up @@ -16,8 +16,13 @@ var assert = chai.assert;

var Client = require('./client/client');
var Server = require('../index');
var soapClient = new Client();
var soapServer = new Server();
var soapClient = new Client(8123);
var soapServer = new Server({
username: 'jjosef',
password: '12345',
company_file: '/company_file',
soap_port: 8123
});

// Start soap Server
soapServer.run();
Expand Down Expand Up @@ -130,4 +135,4 @@ describe('Soap Client', function() {
done();
});
});
});
});