EthStorage Mining #131
EthStorage Mining #131
Conversation
…y proof to use MinTree
…to tm_w3q_sstorage_miner
|
This code has been reviewed, and deployed to test https://testnet.web3q.io:8545/, and do some integration tests. There are still 2 bugs remaining, trace them as follow: put func of system contract 03330001 do not return correct data., ethstorage mine tranction will fail with "execution reverted" |
| @@ -141,7 +141,7 @@ func (g *Governance) NextValidatorsAndPowersAt(remoteChainNumber uint64, hash co | |||
| } | |||
|
|
|||
| // getValidatorsAndPowersFromContract get next validators from contract | |||
| func (g *Governance) getValidatorsAndPowersFromContract(blockHash common.Hash) ([]common.Address, []uint64, error) { | |||
There was a problem hiding this comment.
I am not sure why we need this change here?
There was a problem hiding this comment.
as the Ethereum header change, our etherclient cannot get the correct hash, so when we get validators and powers from the contract from Ethereum, it will fail. so change the getValidatorsAndPowersFromContract using a hash to block number.
There was a problem hiding this comment.
can move out this change and create an issue to check this issue.
related design is added to the following doc:
https://docs.google.com/document/d/1ePI2Bqj069ffKV9eTYbRHCtX5ljyxH3P1BKtU3SGgWU/edit#