Skip to content

Exploded the base exception into several more specialized exception class #89

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 12 commits into
base: master
Choose a base branch
from
+704 −303
Open

Exploded the base exception into several more specialized exception class #89

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
12 commits
Select commit Hold shift + click to select a range
36cdd39
Error handling: Exploded the base exception into several more special…
gplanchat Apr 25, 2023
dbc3cf6
Error handling: Removed an unnecessary and unused parameter inside an…
gplanchat Apr 26, 2023
4f78866
Error handling: Updated the code examples, removing the complex trace…
gplanchat Apr 26, 2023
7bdad86
Error handling: Replaced tabs with spaces in the examples
gplanchat Apr 26, 2023
0f8d507
Apply suggestions from code review
gplanchat Apr 26, 2023
ab7589d
Error handling: Added early returns in the assertStatusCode method
gplanchat Apr 26, 2023
1fcf90a
Merge remote-tracking branch 'origin/feature/better-error-handling' i…
gplanchat Apr 26, 2023
06b2d1d
Error handling: marked as deprecated the checkStatusCode method
gplanchat Apr 26, 2023
fef8627
Error handling: fixed phpstan level 6 errors
gplanchat Apr 26, 2023
bbdcec1
display the server's error message to give more context to the API user
clemzarch May 2, 2023
4b67c65
Merge pull request #2 from php-etl/feature/error-message
clemzarch May 3, 2023
c82b9e4
when the response is not parsable as an XML, display the raw response…
clemzarch May 10, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
Loading