-
Notifications
You must be signed in to change notification settings - Fork 308
Change maximum version #108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Change maximum version #108
Conversation
7c56f1e
to
06a3819
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Ok for updating this, but has it been tested?
And also does it mean it won't be compatible with 9.0.1 for example?
Can't we just remove it, so we don't have to update the version like idiots every time? :D If something doesn't work, we have to fix it anyway. Native modules are not limited to version also, if something comes up, it gets fixed, but no work to do for years in case of most modules. |
Hello, as we can't use the api with the last version of prestashop, can you merge this @Hlavtox ? |
Up! |
when available? |
@@ -47,7 +47,7 @@ class PrestaShopWebservice | |||
/** @var string Minimal version of PrestaShop to use with this library */ | |||
const psCompatibleVersionsMin = '1.4.0.0'; | |||
/** @var string Maximal version of PrestaShop to use with this library */ | |||
const psCompatibleVersionsMax = '8.2.0'; | |||
const psCompatibleVersionsMax = '9.0.0'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
As we haven't tested this module on 9.0.0, maybe we should set 8.2.99 to the max for now 🤔
(In the future, I think that we can remove totally the max compatible version thing here 🤷♂️)
const psCompatibleVersionsMax = '9.0.0'; | |
const psCompatibleVersionsMax = '8.2.99'; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
cc @tleon
Uh oh!
There was an error while loading. Please reload this page.