Skip to content

Change maximum version #108

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

tleon
Copy link

@tleon tleon commented Mar 19, 2025

Questions Answers
Description? Update the maximum version to 9.0.0
Type? bug fix
BC breaks? no
Deprecations? no
Fixed ticket? Fixes #38305
Sponsor company PrestaShop SA
How to test? CI green

@tleon tleon self-assigned this Mar 19, 2025
@tleon tleon force-pushed the Issue-38305-increase-max-version-for-lib branch from 7c56f1e to 06a3819 Compare March 19, 2025 15:06
@github-project-automation github-project-automation bot moved this to Ready for review in PR Dashboard Mar 19, 2025
Copy link

@jolelievre jolelievre left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok for updating this, but has it been tested?

And also does it mean it won't be compatible with 9.0.1 for example?

@Hlavtox
Copy link
Contributor

Hlavtox commented Mar 19, 2025

Can't we just remove it, so we don't have to update the version like idiots every time? :D

If something doesn't work, we have to fix it anyway. Native modules are not limited to version also, if something comes up, it gets fixed, but no work to do for years in case of most modules.

@louisbels
Copy link

Hello, as we can't use the api with the last version of prestashop, can you merge this @Hlavtox ?
Thanks

@boherm
Copy link
Member

boherm commented Mar 28, 2025

Up!
IMHO, it's a good idea to remove this limit but we need to test with v9 before switching.
Maybe, and for now, we can just tolerate a max to 8.2.99 ?
I'm not sure that we have a lot of changes in the future for 8.2x version btw and I think that we could release a new version of this sooner as if we need to check all features for 9x... 🤷‍♂️

@ruilopesW4M
Copy link

when available?

@@ -47,7 +47,7 @@ class PrestaShopWebservice
/** @var string Minimal version of PrestaShop to use with this library */
const psCompatibleVersionsMin = '1.4.0.0';
/** @var string Maximal version of PrestaShop to use with this library */
const psCompatibleVersionsMax = '8.2.0';
const psCompatibleVersionsMax = '9.0.0';
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As we haven't tested this module on 9.0.0, maybe we should set 8.2.99 to the max for now 🤔
(In the future, I think that we can remove totally the max compatible version thing here 🤷‍♂️)

Suggested change
const psCompatibleVersionsMax = '9.0.0';
const psCompatibleVersionsMax = '8.2.99';

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

cc @tleon

@ps-jarvis ps-jarvis moved this from Ready for review to Waiting for author in PR Dashboard Apr 14, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Waiting for author
Development

Successfully merging this pull request may close these issues.

This library is not compatible with this version of PrestaShop. Please upgrade/downgrade this library
8 participants