Skip to content

Add createTemporaryIntegratedConsole to attach opt #5247

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 29, 2025

Conversation

jborean93
Copy link
Contributor

PR Summary

Adds the option createTemporaryIntegratedConsole to the attach configuration. No changes are needed in the code to enable this scenario as it work without any issues right now.

No changes are needed in PSES to enable this. The logic for spawning the temp console exists in the vscode plugin and not PSES.

PR Checklist

  • PR has a meaningful title
  • Summarized changes
  • [NA] PR has tests
  • This PR is ready to merge and is not work in progress
    • If the PR is work in progress, please add the prefix WIP: to the beginning of the title and remove the prefix when the PR is ready

Adds the option `createTemporaryIntegratedConsole` to the attach
configuration. No changes are needed in the code to enable this scenario
as it work without any issues right now.
@Copilot Copilot AI review requested due to automatic review settings July 25, 2025 20:18
Copy link

@Copilot Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a new configuration option createTemporaryIntegratedConsole to the attach debugger configuration in VS Code PowerShell extension. This boolean option allows users to create temporary integrated consoles for debugging sessions, which is particularly useful when debugging PowerShell classes and binary modules.

  • Adds createTemporaryIntegratedConsole boolean property to attach configuration schema
  • Provides ability to override the global user setting on a per-configuration basis
  • Enables temporary console creation for specific debugging scenarios

},
"createTemporaryIntegratedConsole": {
"type": "boolean",
"description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.",
Copy link
Preview

Copilot AI Jul 25, 2025

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are two spaces between sentences in the description. Consider using single spaces for consistency: 'binary modules. Overrides the user setting'

Suggested change
"description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.",
"description": "Determines whether a temporary PowerShell Extension Terminal is created for each debugging session, useful for debugging PowerShell classes and binary modules. Overrides the user setting 'powershell.debugging.createTemporaryIntegratedConsole'.",

Copilot uses AI. Check for mistakes.

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I can but the launch example has the same, wasn't sure if it was intentional or not.

@andyleejordan andyleejordan enabled auto-merge (squash) July 29, 2025 19:08
Copy link
Collaborator

@JustinGrote JustinGrote left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, this is just intellisense niceness

@andyleejordan andyleejordan merged commit 4cea222 into PowerShell:main Jul 29, 2025
4 checks passed
@jborean93 jborean93 deleted the attach-temp-console branch July 29, 2025 19:33
@jborean93
Copy link
Contributor Author

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants