Update dotnet deps + run formatting on all relevant files + some fixes

.config/tsaoptions.json

@@ -1,10 +1,10 @@
 {
-    "instanceUrl": "https://msazure.visualstudio.com",
-    "projectName": "One",
-    "areaPath": "One\\MGMT\\Compute\\Powershell\\Powershell\\PowerShell Core",
-    "notificationAliases": [
-        "adityap@microsoft.com",
-        "americks@microsoft.com",
-        "annavied@microsoft.com"
-    ]
+  "instanceUrl": "https://msazure.visualstudio.com",
+  "projectName": "One",
+  "areaPath": "One\\MGMT\\Compute\\Powershell\\Powershell\\PowerShell Core",
+  "notificationAliases": [
+    "adityap@microsoft.com",
+    "americks@microsoft.com",
+    "annavied@microsoft.com"
+  ]
 }

.editorconfig

@@ -1,9 +1,14 @@
+# Copied from PowerShell/PowerShell 2025-06-28
+# https://github.com/PowerShell/PowerShell/blob/master/.editorconfig
+#
+#
 # EditorConfig is awesome: https://EditorConfig.org
 # .NET coding convention settings for EditorConfig
 # https://learn.microsoft.com/visualstudio/ide/editorconfig-code-style-settings-reference
 #
-# This file was taken from PowerShell/PowerShell 2024-07-13
-# https://github.com/PowerShell/PowerShell/blob/master/.editorconfig
+# This file comes from dotnet repositories:
+# https://github.com/dotnet/runtime/blob/master/.editorconfig
+# https://github.com/dotnet/roslyn/blob/master/.editorconfig
 
 # Top-most EditorConfig file
 root = true
@@ -102,6 +107,8 @@ dotnet_naming_style.camel_case_underscore_style.capitalization = camel_case
 # Suggest more modern language features when available
 dotnet_style_object_initializer = true:suggestion
 dotnet_style_collection_initializer = true:suggestion
+# Background Info: https://github.com/dotnet/runtime/pull/100250
+dotnet_style_prefer_collection_expression = when_types_exactly_match
 dotnet_style_coalesce_expression = true:suggestion
 dotnet_style_null_propagation = true:suggestion
 dotnet_style_explicit_tuple_names = true:suggestion
@@ -116,6 +123,13 @@ csharp_prefer_simple_default_expression = true:suggestion
 
 dotnet_code_quality_unused_parameters = non_public:suggestion
 
+# Dotnet diagnostic settings:
+[*.cs]
+
+# CA1859: Use concrete types when possible for improved performance
+# https://learn.microsoft.com/en-gb/dotnet/fundamentals/code-analysis/quality-rules/ca1859
+dotnet_diagnostic.CA1859.severity = suggestion
+
 # CSharp code style settings:
 [*.cs]
 

.gitignore

@@ -6,6 +6,5 @@ out
 test/**/obj
 test/**/bin
 .vs
-.vscode
 src/code/.vs
-test/testFiles/testScripts/test.ps1
+test/testFiles/testScripts/test.ps1

.markdownlint.json

@@ -0,0 +1,22 @@
+{
+  "default": true,
+  "MD004": false,
+  "MD007": {
+    "indent": 4
+  },
+  "MD013": {
+    "line_length": 240
+  },
+  "MD026": {
+    "punctuation": ".,;:!"
+  },
+  "MD029": {
+    "style": "one"
+  },
+  "MD033": false,
+  "MD034": false,
+  "MD038": false,
+  "MD042": false,
+  "MD024": false,
+  "no-hard-tabs": true
+}

.markdownlintignore

@@ -0,0 +1 @@
+.github/SECURITY.md

.vscode/extensions.json

@@ -1,14 +1,11 @@
 {
-	// See https://go.microsoft.com/fwlink/?LinkId=827846 to learn about workspace recommendations.
-	// Extension identifier format: ${publisher}.${name}. Example: vscode.csharp
-	// List of extensions which should be recommended for users of this workspace.
-	"recommendations": [
-		"EditorConfig.EditorConfig",
+  "recommendations": [
+    "DavidAnson.vscode-markdownlint",
+    "EditorConfig.EditorConfig",
     "ms-dotnettools.csdevkit",
-		"ms-dotnettools.csharp",
-		"ms-vscode.powershell",
-		"patcx.vscode-nuget-gallery"
-	],
-	// List of extensions recommended by VS Code that should not be recommended for users of this workspace.
-	"unwantedRecommendations": []
+    "ms-dotnettools.csharp",
+    "ms-vscode.powershell",
+    "patcx.vscode-nuget-gallery"
+  ],
+  "unwantedRecommendations": []
 }

.vscode/launch.json

@@ -1,33 +1,33 @@
 {
-    "version": "0.2.0",
-    "configurations": [
-        {
-            "name": "Debug PSModule",
-            "type": "coreclr",
-            "request": "launch",
-            "preLaunchTask": "publish",
-            "program": "pwsh",
-            "args": [
-                "-noprofile",
-                "-noexit",
-                "-c",
-                "Import-Module ${workspaceFolder}/out/PowerShellGet.dll -Verbose"
-            ],
-            "cwd": "${workspaceFolder}",
-            "console": "externalTerminal",
-            "stopAtEntry": false,
-            "logging": {
-                "logging.diagnosticsLog.protocolMessages": false,
-                "moduleLoad": false,
-                "exceptions": false,
-                "browserStdOut": false
-            }
-        },
-        {
-            "name": ".NET Core Attach",
-            "type": "coreclr",
-            "request": "attach",
-            "processId": "${command:pickProcess}"
-        }
-    ]
+  "version": "0.2.0",
+  "configurations": [
+    {
+      "name": "Debug PSModule",
+      "type": "coreclr",
+      "request": "launch",
+      "preLaunchTask": "publish",
+      "program": "pwsh",
+      "args": [
+        "-noprofile",
+        "-noexit",
+        "-c",
+        "Import-Module ${workspaceFolder}/out/PowerShellGet.dll -Verbose"
+      ],
+      "cwd": "${workspaceFolder}",
+      "console": "externalTerminal",
+      "stopAtEntry": false,
+      "logging": {
+        "logging.diagnosticsLog.protocolMessages": false,
+        "moduleLoad": false,
+        "exceptions": false,
+        "browserStdOut": false
+      }
+    },
+    {
+      "name": ".NET Core Attach",
+      "type": "coreclr",
+      "request": "attach",
+      "processId": "${command:pickProcess}"
+    }
+  ]
 }

.vscode/settings.json

@@ -1,6 +1,19 @@
 {
-    "csharp.semanticHighlighting.enabled": true,
-    "dotnet.automaticallyCreateSolutionInWorkspace": false,
-    "omnisharp.enableEditorConfigSupport": true,
-    "omnisharp.enableRoslynAnalyzers": true
+  "[csharp]": {
+    "editor.defaultFormatter": "ms-dotnettools.csharp"
+  },
+  "[powershell]": {
+    "editor.defaultFormatter": "ms-vscode.powershell",
+    "files.trimTrailingWhitespace": true
+  },
+  "csharp.semanticHighlighting.enabled": true,
+  "editor.insertSpaces": true,
+  "dotnet.automaticallyCreateSolutionInWorkspace": false,
+  "omnisharp.enableEditorConfigSupport": true,
+  "omnisharp.enableRoslynAnalyzers": true,
+  "powershell.codeFormatting.preset": "OTBS",
+  "powershell.codeFormatting.whitespaceAfterSeparator": true,
+  "powershell.codeFormatting.whitespaceAroundOperator": true,
+  "powershell.codeFormatting.whitespaceBeforeOpenBrace": true,
+  "powershell.codeFormatting.whitespaceBeforeOpenParen": true
 }

.vscode/tasks.json

@@ -1,48 +1,48 @@
 {
-    // See https://go.microsoft.com/fwlink/?LinkId=733558
-    // for the documentation about the tasks.json format
-    "version": "2.0.0",
-    "tasks": [
-        {
-            "label": "build",
-            "command": "dotnet",
-            "type": "shell",
-            "args": [
-                "build",
-                "src/code",
-                // Ask dotnet build to generate full paths for file names.
-                "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
-                "/consoleloggerparameters:NoSummary"
-            ],
-            "group": "build",
-            "presentation": {
-                "revealProblems": "onProblem",
-                "clear": true,
-            },
-            "problemMatcher": "$msCompile"
-        },
-        {
-            "label": "publish",
-            "command": "dotnet",
-            "type": "shell",
-            "args": [
-                "publish",
-                "src/code",
-                "-o",
-                "out",
-                "--framework",
-                "net472",
-                // Ask dotnet build to generate full paths for file names.
-                "/property:GenerateFullPaths=true",
-                // Do not generate summary otherwise it leads to duplicate errors in Problems panel
-                "/consoleloggerparameters:NoSummary"
-            ],
-            "group": "build",
-            "presentation": {
-                "reveal": "silent"
-            },
-            "problemMatcher": "$msCompile"
-        }
-    ]
-}
+  // See https://go.microsoft.com/fwlink/?LinkId=733558
+  // for the documentation about the tasks.json format
+  "version": "2.0.0",
+  "tasks": [
+    {
+      "label": "build",
+      "command": "dotnet",
+      "type": "shell",
+      "args": [
+        "build",
+        "src/code",
+        // Ask dotnet build to generate full paths for file names.
+        "/property:GenerateFullPaths=true",
+        // Do not generate summary otherwise it leads to duplicate errors in Problems panel
+        "/consoleloggerparameters:NoSummary"
+      ],
+      "group": "build",
+      "presentation": {
+        "revealProblems": "onProblem",
+        "clear": true,
+      },
+      "problemMatcher": "$msCompile"
+    },
+    {
+      "label": "publish",
+      "command": "dotnet",
+      "type": "shell",
+      "args": [
+        "publish",
+        "src/code",
+        "-o",
+        "out",
+        "--framework",
+        "net472",
+        // Ask dotnet build to generate full paths for file names.
+        "/property:GenerateFullPaths=true",
+        // Do not generate summary otherwise it leads to duplicate errors in Problems panel
+        "/consoleloggerparameters:NoSummary"
+      ],
+      "group": "build",
+      "presentation": {
+        "reveal": "silent"
+      },
+      "problemMatcher": "$msCompile"
+    }
+  ]
+}

CHANGELOG.md

@@ -1 +1 @@
-The change logs have been split by version and moved to [CHANGELOG](./CHANGELOG).
+The change logs have been split by version and moved to [CHANGELOG](./CHANGELOG).

CHANGELOG/1.0.md

@@ -330,19 +330,19 @@
 - Support searching for all packages from a repository (i.e `Find-PSResource -Name '*'`). Note, wildcard search is not supported for AzureDevOps feed repositories and will write an error message accordingly.
 - Packages found are now unique by Name,Version,Repository.
 - Support searching for and returning packages found across multiple repositories when using wildcard with Repository parameter (i.e `Find-PSResource -Name 'PackageExistingInMultipleRepos' -Repository '*'` will perform an exhaustive search).
-  - PSResourceInfo objects can be piped into: `Install-PSResource`, `Uninstall-PSResource`, `Save-PSResource`. PSRepositoryInfo objects can be piped into: `Unregister-PSResourceRepository`
+    - PSResourceInfo objects can be piped into: `Install-PSResource`, `Uninstall-PSResource`, `Save-PSResource`. PSRepositoryInfo objects can be piped into: `Unregister-PSResourceRepository`
 - For more consistent pipeline support, the following cmdlets have pipeline support for the listed parameter(s):
-  - `Find-PSResource` (Name param, ValueFromPipeline)
-  - `Get-PSResource` (Name param, ValueFromPipeline)
-  - `Install-PSResource` (Name param, ValueFromPipeline)
-  - `Publish-PSResource` (None)
-  - `Save-PSResource` (Name param, ValueFromPipeline)
-  - `Uninstall-PSResource` (Name param, ValueFromPipeline)
-  - `Update-PSResource` (Name param, ValueFromPipeline)
-  - `Get-PSResourceRepository` (Name param, ValueFromPipeline)
-  - `Set-PSResourceRepository` (Name param, ValueFromPipeline)
-  - `Register-PSResourceRepository` (None)
-  - `Unregister-PSResourceRepository` (Name param, ValueFromPipelineByPropertyName)
+    - `Find-PSResource` (Name param, ValueFromPipeline)
+    - `Get-PSResource` (Name param, ValueFromPipeline)
+    - `Install-PSResource` (Name param, ValueFromPipeline)
+    - `Publish-PSResource` (None)
+    - `Save-PSResource` (Name param, ValueFromPipeline)
+    - `Uninstall-PSResource` (Name param, ValueFromPipeline)
+    - `Update-PSResource` (Name param, ValueFromPipeline)
+    - `Get-PSResourceRepository` (Name param, ValueFromPipeline)
+    - `Set-PSResourceRepository` (Name param, ValueFromPipeline)
+    - `Register-PSResourceRepository` (None)
+    - `Unregister-PSResourceRepository` (Name param, ValueFromPipelineByPropertyName)
 - Implement `-Tag` parameter set for `Find-PSResource` (i.e `Find-PSResource -Tag 'JSON'`)
 - Implement `-Type` parameter set for `Find-PSResource` (i.e `Find-PSResource -Type Module`)
 - Implement CommandName and DSCResourceName parameter sets for `Find-PSResource` (i.e `Find-PSResource -CommandName "Get-TargetResource"`).