-
Notifications
You must be signed in to change notification settings - Fork 5.4k
Helpscout new components #17637
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Helpscout new components #17637
Conversation
The latest updates on your projects. Learn more about Vercel for Git ↗︎ 3 Skipped Deployments
|
WalkthroughNew Help Scout integration features were added, including actions to fetch conversation details and threads, and a source to emit events when a conversation's status is updated. Supporting API methods were implemented, a test event fixture was introduced, and the package version and dependencies were updated. Changes
Sequence Diagram(s)sequenceDiagram
participant User
participant Action
participant HelpScoutApp
participant HelpScoutAPI
User->>Action: Trigger "Get Conversation Details"
Action->>HelpScoutApp: getConversation({conversationId, embed})
HelpScoutApp->>HelpScoutAPI: GET /conversations/{conversationId}
HelpScoutAPI-->>HelpScoutApp: Conversation details
HelpScoutApp-->>Action: Return details
Action-->>User: Output conversation details
sequenceDiagram
participant User
participant Action
participant HelpScoutApp
participant HelpScoutAPI
User->>Action: Trigger "Get Conversation Threads"
Action->>HelpScoutApp: getConversationThreads({conversationId, page})
HelpScoutApp->>HelpScoutAPI: GET /conversations/{conversationId}/threads?page={page}
HelpScoutAPI-->>HelpScoutApp: Threads data with pagination
HelpScoutApp-->>Action: Return threads and pagination
Action-->>User: Output threads list
sequenceDiagram
participant HelpScoutWebhook
participant Source
participant User
HelpScoutWebhook->>Source: Send "convo.status" event
Source->>User: Emit event with summary and payload
Assessment against linked issues
Assessment against linked issues: Out-of-scope changes
Poem
Warning There were issues while running some tools. Please review the errors and either fix the tool's configuration or disable the tool if it's a critical failure. 🔧 ESLint
components/help_scout/actions/get-conversation-details/get-conversation-details.mjsOops! Something went wrong! :( ESLint: 8.57.1 Error [ERR_MODULE_NOT_FOUND]: Cannot find package 'jsonc-eslint-parser' imported from /eslint.config.mjs 📜 Recent review detailsConfiguration used: CodeRabbit UI ⛔ Files ignored due to path filters (1)
📒 Files selected for processing (1)
🚧 Files skipped from review as they are similar to previous changes (1)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (3)
✨ Finishing Touches
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
const response = (await this.helpScout.getConversationThreads({ | ||
$, | ||
conversationId: this.conversationId, | ||
}))?._embedded?.threads; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It looks from the docs like maybe this can be paginated? If so, we should offer a maxResults
prop and return a paginated list.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call - it seems the Helpscout API only supports passing a 'page' parameter though, and the page size for this endpoint is fixed at 25 entries. I've added a 'page' prop with this information so users can retrieve older entries if needed
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hi @GTFalcao, LGTM! Ready for QA!
/approve |
Closes #17431
Summary by CodeRabbit
New Features
Chores