feat: display format for oneOf primitive arms #1230
+31
−25
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR adds display of the format for
oneOfschemas with a primitive arm, in line with the display for the field when it is a direct property.Motivation and Context
oneOfschemas with a primitive arm do not display the format, but display the primitive type only. This impacts enums and specific format strings likedate-time. See this issue for more context and examples.How Has This Been Tested?
This change has been tested by manually verifying the change in output display.
Screenshots (if appropriate)
Example of the output without this patch:
This PR correctly displays the format.
Example of the output when this patch is applied:
Types of changes
Checklist