-
Notifications
You must be signed in to change notification settings - Fork 6
build: add restart policy in docker compose file #50
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe updates revise the README to clarify Docker usage by splitting build and run commands and adopting the newer Changes
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (2)
README.md (2)
52-59
: Docker Compose command syntax updated.Switching to
docker compose build
anddocker compose up
aligns with the Docker CLI V2. For background execution, consider runningdocker compose up -d
, or combine build and startup in one step with:docker compose up --build -dThis can streamline the developer workflow.
87-91
: Mirror rebuild instructions.The troubleshooting steps correctly replicate the build/run process. To improve usability, you might explicitly include the
-d
flag for detached mode or add a-f docker-compose.yaml
option if the default file name changes or multiple compose files are in use.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
README.md
(2 hunks)docker-compose.yaml
(1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms (1)
- GitHub Check: Analyze (csharp)
🔇 Additional comments (1)
docker-compose.yaml (1)
7-7
: Restart policy addition is correct.The
restart: unless-stopped
key is properly added under thedocument-service
service, ensuring it will automatically recover from failures unless explicitly stopped.
Task Link
REST-1545
Description
Add key
restart: unless-stopped
for docker-compose yaml filesSummary by CodeRabbit