-
Notifications
You must be signed in to change notification settings - Fork 0
fix: update docker-compose retry policy to unless-stopped #79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe Docker Compose configuration was updated to change the restart policy for the MariaDB and Redis services from Changes
Possibly related PRs
Suggested labels
Suggested reviewers
Poem
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/api/docker-compose.yml (1)
34-34
: DRY the identical restart policy with YAML anchors for easier future changes.All services now share the same directive; you can de-duplicate:
x-restart-policy: &restart_policy restart: unless-stopped services: transcript-summarizer-api: <<: *restart_policy ... transcript-summarizer-mariadb: <<: *restart_policy ... transcript-summarizer-redis: <<: *restart_policy ...This keeps the policy changeable in one place.
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (1)
apps/api/docker-compose.yml
(2 hunks)
🔇 Additional comments (2)
apps/api/docker-compose.yml (2)
20-20
: Consistent restart policy – change meets objective.
restart: unless-stopped
is now applied to MariaDB, matching the API service and fulfilling OSXT-1545.
No functional concerns.
18-20
: ```shell
#!/bin/bashVerify image tags in the docker-compose file
grep -R "image:.*latest" -n apps/api/docker-compose.yml || echo "No 'latest' tags found"
</details> </blockquote></details> </details> <!-- This is an auto-generated comment by CodeRabbit for review status -->
API PR Checklist
Task Link
Osmosys Developers must include the Pinestem task link in the PR.
OSXT-1545
Pre-requisites
.env.example
file with the required values as applicable.PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Note: Reviewer should ensure that the checklist and description have been populated and followed correctly, and the PR should be merged only after resolving all conversations and verifying that CI checks pass.
Description:
Update retry policy to unless-stopped for all docker-compose services
Summary by CodeRabbit