-
Notifications
You must be signed in to change notification settings - Fork 0
build: migrate to docker compose v2 #74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
WalkthroughThe changes remove the version declaration from the Docker Compose configuration file and update documentation to use the modern Changes
Possibly related PRs
Suggested reviewers
Poem
Tip ⚡️ Faster reviews with caching
Enjoy the performance boost—your workflow just got faster. 📜 Recent review detailsConfiguration used: CodeRabbit UI 📒 Files selected for processing (1)
✅ Files skipped from review due to trivial changes (1)
Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
SupportNeed help? Create a ticket on our support page for assistance with any issues or questions. Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 0
🧹 Nitpick comments (1)
apps/api/docs/production-setup.md (1)
120-120
: Convert step emphasis to a markdown heading
Markdown lint warns about using emphasis (**...**
) instead of a heading. Consider changing this line to a level-3 heading for consistency:- **Step 3: Start the Docker Containers** + ### Step 3: Start the Docker Containers🧰 Tools
🪛 markdownlint-cli2 (0.17.2)
120-120: Emphasis used instead of a heading
null(MD036, no-emphasis-as-heading)
📜 Review details
Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro
📒 Files selected for processing (2)
apps/api/docker-compose.yml
(0 hunks)apps/api/docs/production-setup.md
(3 hunks)
💤 Files with no reviewable changes (1)
- apps/api/docker-compose.yml
🧰 Additional context used
🪛 markdownlint-cli2 (0.17.2)
apps/api/docs/production-setup.md
120-120: Emphasis used instead of a heading
null
(MD036, no-emphasis-as-heading)
🔇 Additional comments (6)
apps/api/docs/production-setup.md (6)
52-52
: Approve whitespace cleanup on environment variable
The trailing space has been removed from theCOMPOSE_PROJECT_NAME
assignment, improving markdown formatting.
117-117
: Use updated Docker Compose v2 syntax for build
Replacingdocker-compose build
withdocker compose build
aligns with Docker Compose v2 conventions.
125-125
: Use updated Docker Compose v2 syntax for up
Switchingdocker-compose up -d
todocker compose up -d
is correct for v2 compatibility.
145-145
: Use updated Docker Compose v2 syntax for down
Changingdocker-compose down
todocker compose down
follows the v2 command structure.
151-151
: Use updated Docker Compose v2 syntax for rebuild
Updatingdocker-compose build
todocker compose build
maintains consistency with v2.
157-157
: Use updated Docker Compose v2 syntax for restart
Replacingdocker-compose up -d
withdocker compose up -d
is the correct v2 approach.
API PR Checklist
Task Link
Osmosys Developers must include the Pinestem task link in the PR.
REST-1421
Pre-requisites
PR Details
PR details have been updated as per the given format (see below)
feat: add admin login endpoint
)Additional Information
ready for review
should be added if the PR is ready to be reviewed)Description:
version
keywordAdditional notes:
Summary by CodeRabbit
Documentation
docker compose
syntax instead of the deprecateddocker-compose
.Chores