Skip to content

build: update portal dependencies #69

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 13 commits into from
Apr 7, 2025

Conversation

kshitij-k-osmosys
Copy link
Contributor

@kshitij-k-osmosys kshitij-k-osmosys commented Feb 27, 2025

Portal PR Checklist

Task Link

Osmosys Developers must include the Pinestem task link in the PR.

REST-1120

Pre-requisites

  • I have gone through the Contributing guidelines for Submitting a Pull Request (PR) and ensured that this is not a duplicate PR.
  • I have performed preliminary testing to ensure that any existing features are not impacted and any new features are working as expected.

PR Details

PR details have been updated as per the given format (see below)

  • PR title adheres to the format specified in guidelines (e.g., feat: add admin login page)
  • Description has been added
  • Related changes have been added (optional)
  • Screenshots have been added (optional)
  • Pending actions have been added (optional)
  • Any other additional notes have been added (optional)

Additional Information

  • Appropriate label(s) have been added (ready for review should be added if the PR is ready to be reviewed)
  • Assignee(s) and reviewer(s) have been added (optional)

Description:

Update npm dependencies for portal

Screenshots:

image

Summary by CodeRabbit

  • Chores
    • Updated underlying dependencies to enhance overall stability, performance, and compatibility, ensuring a smoother and more reliable user experience.

@kshitij-k-osmosys kshitij-k-osmosys self-assigned this Feb 27, 2025
Copy link
Contributor

coderabbitai bot commented Feb 27, 2025

Walkthrough

This pull request updates the dependency versions within the apps/portal/package.json file. The changes involve version bumps for various packages in both the dependencies and devDependencies sections, affecting libraries such as @apollo/client, graphql, prismjs, rxjs, tslib, Angular CLI tooling, ESLint tools, Jasmine testing libraries, and Prettier. These updates are strictly version changes aimed at maintaining current package releases.

Changes

File(s) Change Summary
apps/portal/package.json - Dependencies: Updated versions for @apollo/client (^3.11.4 → ^3.13.6), graphql (^16.9.0 → ^16.10.0), prismjs (^1.29.0 → ^1.30.0), rxjs (~7.8.1 → ~7.8.2), tslib (^2.6.3 → ^2.8.1).
- DevDependencies: Updated versions for @angular-devkit/build-angular (^18.2.0 → ^18.2.14), @angular/cli (^18.2.0 → ^18.2.14), @eslint/js (^9.9.0 → ^9.24.0), @types/jasmine (~5.1.4 → ~5.1.7), eslint-plugin-prettier (^5.2.1 → ^5.2.6), jasmine-core (~5.2.0 → ~5.6.0), and prettier (^3.3.3 → ^3.5.3).

Possibly related PRs

Suggested labels

Ready for review

Suggested reviewers

  • xixas
  • osm-vishnukyatannawar

Poem

I'm a rabbit with a joyful hop,
Chewing on versions that just don't stop.
Bumping dependencies, crisp and new,
In the code garden, updates brew!
Hoppy leaps in every line—let's code and rhyme!
🐇✨


📜 Recent review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 4ad30bd and 0900de6.

⛔ Files ignored due to path filters (1)
  • apps/portal/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (1)
  • apps/portal/package.json (2 hunks)
🚧 Files skipped from review as they are similar to previous changes (1)
  • apps/portal/package.json

🪧 Tips

Chat

There are 3 ways to chat with CodeRabbit:

  • Review comments: Directly reply to a review comment made by CodeRabbit. Example:
    • I pushed a fix in commit <commit_id>, please review it.
    • Generate unit testing code for this file.
    • Open a follow-up GitHub issue for this discussion.
  • Files and specific lines of code (under the "Files changed" tab): Tag @coderabbitai in a new review comment at the desired location with your query. Examples:
    • @coderabbitai generate unit testing code for this file.
    • @coderabbitai modularize this function.
  • PR comments: Tag @coderabbitai in a new PR comment to ask questions about the PR branch. For the best results, please provide a very specific query, as very limited context is provided in this mode. Examples:
    • @coderabbitai gather interesting stats about this repository and render them as a table. Additionally, render a pie chart showing the language distribution in the codebase.
    • @coderabbitai read src/utils.ts and generate unit testing code.
    • @coderabbitai read the files in the src/scheduler package and generate a class diagram using mermaid and a README in the markdown format.
    • @coderabbitai help me debug CodeRabbit configuration file.

Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments.

CodeRabbit Commands (Invoked using PR comments)

  • @coderabbitai pause to pause the reviews on a PR.
  • @coderabbitai resume to resume the paused reviews.
  • @coderabbitai review to trigger an incremental review. This is useful when automatic reviews are disabled for the repository.
  • @coderabbitai full review to do a full review from scratch and review all the files again.
  • @coderabbitai summary to regenerate the summary of the PR.
  • @coderabbitai generate docstrings to generate docstrings for this PR.
  • @coderabbitai resolve resolve all the CodeRabbit review comments.
  • @coderabbitai plan to trigger planning for file edits and PR creation.
  • @coderabbitai configuration to show the current CodeRabbit configuration for the repository.
  • @coderabbitai help to get help.

Other keywords and placeholders

  • Add @coderabbitai ignore anywhere in the PR description to prevent this PR from being reviewed.
  • Add @coderabbitai summary to generate the high-level summary at a specific location in the PR description.
  • Add @coderabbitai anywhere in the PR title to generate the title automatically.

CodeRabbit Configuration File (.coderabbit.yaml)

  • You can programmatically configure CodeRabbit by adding a .coderabbit.yaml file to the root of your repository.
  • Please see the configuration documentation for more information.
  • If your editor has YAML language server enabled, you can add the path at the top of this file to enable auto-completion and validation: # yaml-language-server: $schema=https://coderabbit.ai/integrations/schema.v2.json

Documentation and Community

  • Visit our Documentation for detailed information on how to use CodeRabbit.
  • Join our Discord Community to get help, request features, and share feedback.
  • Follow us on X/Twitter for updates and announcements.

@kshitij-k-osmosys kshitij-k-osmosys marked this pull request as ready for review February 27, 2025 12:03
@kshitij-k-osmosys kshitij-k-osmosys marked this pull request as draft February 27, 2025 12:03
Copy link
Contributor

@coderabbitai coderabbitai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Actionable comments posted: 0

🧹 Nitpick comments (1)
apps/api/package.json (1)

93-93: TypeScript Compiler Update.
The jump to "typescript": "^5.7.3" is significant. This update should be tested comprehensively to catch any type errors or compiler warnings introduced by the new version.

📜 Review details

Configuration used: CodeRabbit UI
Review profile: CHILL
Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 0f0ae60 and 4ad30bd.

⛔ Files ignored due to path filters (2)
  • apps/api/package-lock.json is excluded by !**/package-lock.json
  • apps/portal/package-lock.json is excluded by !**/package-lock.json
📒 Files selected for processing (2)
  • apps/api/package.json (2 hunks)
  • apps/portal/package.json (2 hunks)
🔇 Additional comments (28)
apps/portal/package.json (10)

26-26: Apollo Client Version Update.
The update to "@apollo/client": "^3.13.1" appears intentional. Please verify that this version is fully compatible with the portal’s Apollo integration and consistent with other parts of the project.


35-35: GraphQL Version Consistency.
The upgrade to "graphql": "^16.10.0" aligns with the API’s dependency changes. Ensure that any GraphQL queries, schema stitching, or integrations are tested for compatibility with this minor bump.


40-40: RxJS Version Bump.
Updating "rxjs" from a previous minor version to "~7.8.2" should be backward-compatible; however, please run the usual reactive flows regression tests to confirm behavior remains unchanged.


41-41: Verify tslib Dependency.
The declaration of "tslib": "^2.8.1" should be double-checked to confirm that the change was intentional and is compatible with the Angular compiler setup.


45-45: Angular Devkit Update.
The update to "@angular-devkit/build-angular": "^18.2.14" looks standard. Please ensure that the build process and CLI tooling remain smooth with this version.


51-51: Angular CLI Version Alignment.
The upgrade to "@angular/cli": "^18.2.14" is in step with the devkit update. Confirm that local development commands and build scripts continue to function as expected.


54-54: ESLint JS Tooling Update.
The update to "@eslint/js": "^9.21.0" is consistent with our recent tooling improvements. Verify that lint rules and code quality checks are not adversely affected.


56-56: Jasmine Type Definitions Updated.
The bumped version for "@types/jasmine": "~5.1.7" should improve type checks for tests. It’s worthwhile to run the test suite to ensure there are no type conflicts.


62-62: eslint-plugin-prettier Update.
Updating "eslint-plugin-prettier": "^5.2.3" is aligned with similar changes in the API project. Confirm that the integrated Prettier formatting rules remain consistent during linting operations.


70-70: Prettier Version Upgrade.
The update to "prettier": "^3.5.2" should bring improvements and bug fixes. Make sure that the code formatting scripts and pre-commit hooks (if any) continue to operate as expected.

apps/api/package.json (18)

33-33: @apollo/server Dependency Update.
The version bump to "@apollo/server": "^4.11.3" should be verified against the API’s GraphQL setup. Ensure that all server-side Apollo integrations are fully tested after this update.


47-47: Bull Package Version Bump.
Upgrading "bull": "^4.16.5" is likely for bug fixes or performance improvements. Please validate that any job queue-related functionalities behave as expected post-update.


50-50: dotenv Update Verification.
The change to "dotenv": "^16.4.7" may include important patches. Ensure that environment variable loading and configuration across environments continue to work correctly.


51-51: fs-extra Dependency Update.
Upgrading to "fs-extra": "^11.3.0" should provide improved file handling. Please run tests that involve file operations to verify there are no unexpected side effects.


52-52: GraphQL Update in API.
The update to "graphql": "^16.10.0" mirrors changes in the portal. Confirm that this version change does not introduce breaking schema or query issues in the API.


53-53: graphql-tools Version Upgrade.
Updating "graphql-tools": "^9.0.15" may affect schema merging or resolver composition. Validate all GraphQL tooling functionalities to avoid deprecation or incompatibility issues.


56-56: mariadb Package Update.
The bump to "mariadb": "^3.4.0" should be evaluated for any changes in default connection behaviors. Verify database connectivity and performance with this version.


57-57: mysql2 Version Bump.
Upgrading "mysql2": "^3.12.0" necessitates a check of all MySQL-related operations and queries to ensure full compatibility with the new release.


58-58: nest-winston Upgrade.
The update to "nest-winston": "^1.10.2" should be tested to confirm that the integrated logging capabilities remain stable and that the configuration needs no adjustments.


59-59: openai Dependency Upgrade.
The version increase to "openai": "^4.85.4" requires verification that any OpenAI API integrations continue to work as before and that no breaking changes affect our API calls.


63-63: RxJS Consistency Update.
Changing "rxjs": "^7.8.2" in the API ensures consistency with the portal. Please confirm that reactive patterns and observable behaviors are thoroughly tested after this update.


66-66: Winston Logging Version Bump.
Upgrading "winston": "^3.17.0" may bring important fixes. Ensure that all logging transports and configurations across the API work as anticipated.


70-70: ESLint JS DevDependency Update.
The update to "@eslint/js": "^9.21.0" in devDependencies is consistent across the project. This should maintain the linting standards for the API code.


76-76: Jest Type Definitions Update.
The bump to "@types/jest": "^29.5.14" ensures updated type definitions for the testing environment. Run the test suite to catch any potential type mismatches.


83-83: eslint-plugin-prettier DevDependency.
Upgrading "eslint-plugin-prettier": "^5.2.3" helps keep formatting consistent across the development workflow. Ensure that no linting rules are inadvertently broken.


86-86: Prettier Version Alignment.
The update to "prettier": "^3.5.2" should be compatible with our current code formatting workflow. Double-check that format-on-save and pre-commit hooks (if any) still run correctly.


89-89: ts-jest Dependency Update.
The version bump to "ts-jest": "^29.2.6" needs to be validated with the Jest configuration to ensure smooth TypeScript testing.


90-90: ts-loader Version Update.
The upgrade to "ts-loader": "^9.5.2" is intended to improve build efficiency. Verify that the build process compiles TypeScript files without errors.

@kshitij-k-osmosys kshitij-k-osmosys added bug Something isn't working dependencies Pull requests that update a dependency file labels Feb 28, 2025
@kshitij-k-osmosys kshitij-k-osmosys changed the title build: update portal dependencies (February 2025) build: update portal dependencies Apr 4, 2025
@kshitij-k-osmosys kshitij-k-osmosys added the help wanted Extra attention is needed label Apr 4, 2025
@kshitij-k-osmosys kshitij-k-osmosys removed the bug Something isn't working label Apr 7, 2025
@kshitij-k-osmosys kshitij-k-osmosys marked this pull request as ready for review April 7, 2025 07:43
@osm-vishnukyatannawar osm-vishnukyatannawar merged commit dd5afc8 into main Apr 7, 2025
6 checks passed
@osm-vishnukyatannawar osm-vishnukyatannawar deleted the build/update-portal-dependencies branch April 7, 2025 08:05
@coderabbitai coderabbitai bot mentioned this pull request Jun 18, 2025
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies Pull requests that update a dependency file help wanted Extra attention is needed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants