Skip to content

Conversation

Amxx
Copy link
Collaborator

@Amxx Amxx commented Sep 26, 2025

This should be merged into master then cherrypicked onto release-v5.5

Since this is a new contract that was first released in v5.5.0-rc.0, we don't need a changelog entry

@Amxx Amxx added this to the 5.5-final milestone Sep 26, 2025
@Amxx Amxx requested a review from a team as a code owner September 26, 2025 13:58
Copy link

changeset-bot bot commented Sep 26, 2025

⚠️ No Changeset found

Latest commit: 35292ba

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

coderabbitai bot commented Sep 26, 2025

Walkthrough

Documentation-only update in contracts/utils/cryptography/verifiers/ERC7913WebAuthnVerifier.sol. The contract’s doc block now includes the custom tag @Custom:stateless and an additional empty separator line. There are no modifications to logic, type signatures, control flow, or public/exported declarations.

Suggested labels

area: upgradeability

Pre-merge checks and finishing touches

✅ Passed checks (3 passed)
Check name Status Explanation
Title Check ✅ Passed The title accurately and succinctly describes the primary change, namely marking the ERC7913WebAuthnVerifier contract as stateless by adding the documentation tag.
Description Check ✅ Passed The description explains the merge strategy and justification regarding the changelog for the new contract, which is relevant to the pull request context even if it does not detail the specific code change.
Docstring Coverage ✅ Passed No functions found in the changes. Docstring coverage check skipped.
✨ Finishing touches
🧪 Generate unit tests
  • Create PR with unit tests
  • Post copyable unit tests in a comment

📜 Recent review details

Configuration used: CodeRabbit UI

Review profile: CHILL

Plan: Pro

📥 Commits

Reviewing files that changed from the base of the PR and between 5eb047a and 35292ba.

📒 Files selected for processing (1)
  • contracts/utils/cryptography/verifiers/ERC7913WebAuthnVerifier.sol (1 hunks)
⏰ Context from checks skipped due to timeout of 90000ms. You can increase the timeout in your CodeRabbit configuration to a maximum of 15 minutes (900000ms). (6)
  • GitHub Check: slither
  • GitHub Check: coverage
  • GitHub Check: tests-foundry
  • GitHub Check: tests
  • GitHub Check: tests-upgradeable
  • GitHub Check: halmos
🔇 Additional comments (1)
contracts/utils/cryptography/verifiers/ERC7913WebAuthnVerifier.sol (1)

19-21: Doc tag addition looks correct.

Marking the verifier as stateless matches its storage-free implementation.

Tip

👮 Agentic pre-merge checks are now available in preview!

Pro plan users can now enable pre-merge checks in their settings to enforce checklists before merging PRs.

  • Built-in checks – Quickly apply ready-made checks to enforce title conventions, require pull request descriptions that follow templates, validate linked issues for compliance, and more.
  • Custom agentic checks – Define your own rules using CodeRabbit’s advanced agentic capabilities to enforce organization-specific policies and workflows. For example, you can instruct CodeRabbit’s agent to verify that API documentation is updated whenever API schema files are modified in a PR. Note: Upto 5 custom checks are currently allowed during the preview period. Pricing for this feature will be announced in a few weeks.

Please see the documentation for more information.

Example:

reviews:
  pre_merge_checks:
    custom_checks:
      - name: "Undocumented Breaking Changes"
        mode: "warning"
        instructions: |
          Pass/fail criteria: All breaking changes to public APIs, CLI flags, environment variables, configuration keys, database schemas, or HTTP/GraphQL endpoints must be documented in the "Breaking Change" section of the PR description and in CHANGELOG.md. Exclude purely internal or private changes (e.g., code not exported from package entry points or explicitly marked as internal).

Please share your feedback with us on this Discord post.


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands and usage tips.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant