Skip to content

Don't run view inlining with fast_path_optimizer #33086

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

ggevay
Copy link
Contributor

@ggevay ggevay commented Jul 20, 2025

This moves the inline_views call in optimize_dataflow into the non-fast_path_optimizer branch. There should be no behavior change from this, because the fast_path_optimizer bool can only be set if create_fast_path_plan already recognized a fast path opportunity before inlining, in which case not inlining is needed.

Besides a slight speedup, this also makes the code's intention more clear, i.e., that fast_path_optimizer only works when no inlining is needed.

Motivation

Tips for reviewer

Checklist

  • This PR has adequate test coverage / QA involvement has been duly considered. (trigger-ci for additional test/nightly runs)
  • This PR has an associated up-to-date design doc, is a design doc (template), or is sufficiently small to not require a design.
  • If this PR evolves an existing $T ⇔ Proto$T mapping (possibly in a backwards-incompatible way), then it is tagged with a T-proto label.
  • If this PR will require changes to cloud orchestration or tests, there is a companion cloud PR to account for those changes that is tagged with the release-blocker label (example).
  • If this PR includes major user-facing behavior changes, I have pinged the relevant PM to schedule a changelog post.

@ggevay ggevay requested a review from a team as a code owner July 20, 2025 14:19
@ggevay ggevay added A-optimization Area: query optimization and transformation A-ADAPTER Topics related to the ADAPTER layer labels Jul 20, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
A-ADAPTER Topics related to the ADAPTER layer A-optimization Area: query optimization and transformation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant