Don't run view inlining with fast_path_optimizer
#33086
Open
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves the
inline_views
call inoptimize_dataflow
into the non-fast_path_optimizer
branch. There should be no behavior change from this, because thefast_path_optimizer
bool can only be set ifcreate_fast_path_plan
already recognized a fast path opportunity before inlining, in which case not inlining is needed.Besides a slight speedup, this also makes the code's intention more clear, i.e., that
fast_path_optimizer
only works when no inlining is needed.Motivation
Tips for reviewer
Checklist
$T ⇔ Proto$T
mapping (possibly in a backwards-incompatible way), then it is tagged with aT-proto
label.