-
Notifications
You must be signed in to change notification settings - Fork 3.5k
Pull Request: Adding New Control NumericUpDown Control to Material Design XAML Toolkit #3175
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Pull Request: Adding New Control NumericUpDown Control to Material Design XAML Toolkit #3175
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One other thing that would be good to do is write some UI tests for this control. If you need any help setting that up, let me know.
MainDemo.Wpf/NumericUpDown.xaml
Outdated
<smtx:XamlDisplay Margin="10,5" | ||
VerticalAlignment="Top" | ||
UniqueKey="numericUpDown_default"> | ||
<materialDesign:NumericUpDown /> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Would be nice to put in a few more examples showing the commands, Min and Max, and any other styles.
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
Any update on this? @Asivaprasadam? Would be cool to have this in my project, this is exactly what I need! |
@tim-gromeyer I have changed my work abit and switched from UI development to more of a backend development. But I'll check with the progress and do an update possibly asap, but lets say optimally by end of Jan worst case by march. Feel free to take over too! |
799b4e4
to
dfe8f13
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a few comments to consider.
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
MaterialDesignThemes.Wpf/Themes/MaterialDesignTheme.NumericUpDown.xaml
Outdated
Show resolved
Hide resolved
- Auto generated control template added. - Auto generated style from Generic.xaml moved to the specific style file (MaterialDesignTheme.NumericUpDown.xaml).
Adding UI tests
Reverted attached debugger change in base UI tests class
The behavior should match that of Slider.
defe04b
to
ee5f24f
Compare
Pull Request: Adding NumericUpDown control to Material Design
Preface
Hello everyone,
This is my first contribution to a GitHub project, and I am excited to be a part of the MaterialDesignXamlToolkit community. I have been working on this NumericUpDown control for Material Design, and I believe it will be a valuable addition to the project.
I must admit that my lack of experience contributing to open-source projects has delayed me in committing to this code. However, I have decided that I don't want to delay it any further by waiting to complete all the planned improvements before submitting my contribution when there is a strong community that can help me out with my 1st contribution.
Since this is my first GitHub contribution, I would appreciate any feedback and advice you can provide. I am eager to learn from more experienced developers and improve my skills, so please do not hesitate to give me constructive criticism and suggestions for improvements. I am committed to contributing to this project and look forward to continuing to learn and improve.
Thank you for taking the time to review my contribution, and I look forward to your feedback.
Description
This pull request adds a new NumericUpDown control to the Material Design project. The control provides a user-friendly way to input numeric values and is designed to fit seamlessly into the Material Design UI.
Changes Made
Pending Potential Changes
Screenshots
Related Issues
Additional Notes
None