MDEV-36482: Make liburing work WITH_MSAN=ON #4195
Open
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
A read from liburing has its output buffer as defined by the nature of the system call. Instrumenting the library proved difficult as the completion events don't include the opcode or pointers that where there on submission. It was just easier to do this in the application code.
grooverdan
added
the
MariaDB Foundation
dr-m
approved these changes
Jul 21, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
same concept as #3949.
A read from liburing has its output buffer as defined by the nature of the system call.
Instrumenting the library proved difficult as the
completion events don't include the opcode or pointers that where there on submission. It was just easier to do this in the application code.
Release Notes
non-user facing.
How can this PR be tested?
compile in msan environment and run test suite with uring.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check