MDEV-37157 Fix rownum in having clause and subquery #4166
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
|
zhaoxh16
force-pushed
the
rownum-in-subquery-fix
branch
from
9a0b8b9 to
36ccce1
Compare
zhaoxh16
changed the title
zhaoxh16
force-pushed
the
rownum-in-subquery-fix
branch
from
36ccce1 to
b089d8b
Compare
zhaoxh16
changed the title
zhaoxh16
force-pushed
the
rownum-in-subquery-fix
branch
from
b089d8b to
dfd2b42
Compare
svoj
added
the
External Contribution
Description ========== When rownum used in HAVING without GROUP BY, accepted_rows should be incremented even if the having cond's value is 0. When rownum used in subquery 1. Forbid subquery transformed to semi join. 2. New conditions must be added into having clause when doing in2exists.
zhaoxh16
force-pushed
the
rownum-in-subquery-fix
branch
from
dfd2b42 to
b57ee59
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When rownum used in HAVING without GROUP BY, accepted_rows should be incremented even if the having cond's value is 0.
When rownum used in subquery
Release Notes
Fix bug in rownum function when using in having or subquery
How can this PR be tested?
see new test in main.rownum
If the changes are not amenable to automated testing, please explain why not and carefully describe how to test manually.
Basing the PR against the correct MariaDB version
mainbranch.PR quality check