Skip to content

[wip] use rails 8.0 #194

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from
Open

[wip] use rails 8.0 #194

wants to merge 1 commit into from

Conversation

kbrock
Copy link
Member

@kbrock kbrock commented Jul 10, 2025

Started as a litmus test. But now I'm wondering

I'd be up for supporting 7.2 and 8.0 branches
May want to get the virtual_attribute :through changes into 7.2.1 before merging this / creating another branch

@miq-bot
Copy link
Member

miq-bot commented Jul 10, 2025

Checked commit kbrock@fd44084 with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint
2 files checked, 0 offenses detected
Everything looks fine. ⭐

@miq-bot
Copy link
Member

miq-bot commented Jul 18, 2025

This pull request is not mergeable. Please rebase and repush.

@jrafanie
Copy link
Member

Looks like a good start... should we support testing multiple rails versions here? In other words, resurrect some of the changes here in ci.yaml and Gemfile: 20b6106

@kbrock
Copy link
Member Author

kbrock commented Jul 24, 2025

@jrafanie in order to simplify things in the 6.1, 6.2, and 7.0 world, it made sense to version virtual attributes based upon rails version. The internals just started deviating too much. So we have a branch per active record version.

This is the way that the active record jdbc driver did versioning, and I found it much easier to support than when they had a single version of the driver that supported all versions of active record.

One example from our code is dropping load_schema calls in 7.2. There would be a bunch of checks on the active record version to support both rails 7.1 and 7.2.

Currently, rails 7.2 and 8.0 seems to work with the same virtual attributes code, but I'm hesitant to merge the versions.

It does make sense holding off on making master support rails 8.0, at least until we stabilize manageiq core.

WIP: lets not make master based upon rails 8.0 until we upgrade manageiq master to rails 8.0.

@kbrock kbrock changed the title use rails 8.0 [wip] use rails 8.0 Jul 24, 2025
@kbrock kbrock added the wip Work in progress label Jul 24, 2025
@jrafanie
Copy link
Member

Yeah, I was just considering having 7.2 and 8.0 in the matrix with 8.0 as allowed failures if needed.

@kbrock
Copy link
Member Author

kbrock commented Jul 24, 2025

We could do that. We always build with the "current version" of rails (i.e.: 7.2).

We also have a build for the next (or latest?) version of rails as a heads up for our future upgrades?

@jrafanie
Copy link
Member

yeah, on the main branch, we should certainly try to support the current supported rails and any newer ones we're trying to get to green with allow failures or something similar.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
dependencies wip Work in progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants