-
Notifications
You must be signed in to change notification settings - Fork 12
[wip] use rails 8.0 #194
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
[wip] use rails 8.0 #194
Conversation
Checked commit kbrock@fd44084 with ruby 3.1.7, rubocop 1.56.3, haml-lint 0.64.0, and yamllint |
This pull request is not mergeable. Please rebase and repush. |
Looks like a good start... should we support testing multiple rails versions here? In other words, resurrect some of the changes here in ci.yaml and Gemfile: 20b6106 |
@jrafanie in order to simplify things in the 6.1, 6.2, and 7.0 world, it made sense to version virtual attributes based upon rails version. The internals just started deviating too much. So we have a branch per active record version. This is the way that the active record jdbc driver did versioning, and I found it much easier to support than when they had a single version of the driver that supported all versions of active record. One example from our code is dropping Currently, rails 7.2 and 8.0 seems to work with the same virtual attributes code, but I'm hesitant to merge the versions. It does make sense holding off on making WIP: lets not make |
Yeah, I was just considering having 7.2 and 8.0 in the matrix with 8.0 as allowed failures if needed. |
We could do that. We always build with the "current version" of rails (i.e.: 7.2). We also have a build for the next (or latest?) version of rails as a heads up for our future upgrades? |
yeah, on the main branch, we should certainly try to support the current supported rails and any newer ones we're trying to get to green with allow failures or something similar. |
Started as a litmus test. But now I'm wondering
I'd be up for supporting 7.2 and 8.0 branches
May want to get the
virtual_attribute :through
changes into 7.2.1 before merging this / creating another branch