-
Notifications
You must be signed in to change notification settings - Fork 2
chore: add semantic release #34
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Wdyt about converting this to draft so we can focus on the other PR first (#33)?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I made a first round of comments. 🙂
Besides, can you change the title of the PR to follow the conventional commits and add a small description, especially to detail a bit how the semantic release should work, please?
And don't we want to remove the former release jobs, so that it is replaced by the new one?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
There are sill a few things to fix. Besides, could you add in your PR description for instance what tests did you run or what documentation did you follow, to support your code? Typically, have you checked this guide?
Besides, you didn't remove the former release file
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, you're good to go! 🥳
I can't recall if you still need to do it, but if you need it don't forget to set the relevant GH secrets
Description
Add the python semantic release to this sdk, it should release the package automatically when we push on main, it also released based on commit messages following the Conventional Commits
Here is the reference
https://python-semantic-release.readthedocs.io/en/latest/configuration/configuration-guides/uv_integration.html
test with: uv run semantic-release version --no-push
Checklist
make install-dev
andmake test
README.md
if my changes affected itlinkup/_version.py
if I plan on creating a new release