Skip to content

chore: add semantic release #34

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 23 commits into
base: main
Choose a base branch
from
Open

Conversation

juliette0704
Copy link
Contributor

@juliette0704 juliette0704 commented Jul 9, 2025

Description

Add the python semantic release to this sdk, it should release the package automatically when we push on main, it also released based on commit messages following the Conventional Commits

Here is the reference
https://python-semantic-release.readthedocs.io/en/latest/configuration/configuration-guides/uv_integration.html

test with: uv run semantic-release version --no-push

Checklist

  • I have run the tests locally with make install-dev and make test
  • I have updated the README.md if my changes affected it
  • I have updated the package version in linkup/_version.py if I plan on creating a new release

@juliette0704 juliette0704 marked this pull request as ready for review July 9, 2025 08:04
@juliette0704 juliette0704 requested a review from cjumel July 9, 2025 08:05
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Wdyt about converting this to draft so we can focus on the other PR first (#33)?

@juliette0704 juliette0704 marked this pull request as draft July 11, 2025 08:39
@cjumel cjumel mentioned this pull request Jul 15, 2025
3 tasks
@juliette0704 juliette0704 marked this pull request as ready for review July 17, 2025 07:59
@juliette0704 juliette0704 requested a review from cjumel July 17, 2025 08:00
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I made a first round of comments. 🙂
Besides, can you change the title of the PR to follow the conventional commits and add a small description, especially to detail a bit how the semantic release should work, please?
And don't we want to remove the former release jobs, so that it is replaced by the new one?

@juliette0704 juliette0704 changed the title Chore/add semantic release Chore: add semantic release Jul 18, 2025
@juliette0704 juliette0704 requested a review from cjumel July 18, 2025 08:49
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

There are sill a few things to fix. Besides, could you add in your PR description for instance what tests did you run or what documentation did you follow, to support your code? Typically, have you checked this guide?

Besides, you didn't remove the former release file

@juliette0704 juliette0704 requested a review from cjumel July 21, 2025 14:52
semantic-release and others added 3 commits July 25, 2025 13:32
Automatically generated by python-semantic-release
@juliette0704 juliette0704 changed the title Chore: add semantic release chore: add semantic release Jul 25, 2025
Copy link
Contributor

@cjumel cjumel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, you're good to go! 🥳
I can't recall if you still need to do it, but if you need it don't forget to set the relevant GH secrets

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants