Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Updating root monorepo
README
to be relevant to V8Sections Not Included
The following are sections from the existing
README
that were removed in the recreation of theREADME
in this PR:bun run test:local
in this PR because when running it I got the following error and thelocal-tests
dir doesn't exist anymore:Cannot find module local-tests/build.mjs
Creating a new library
section that uses the command:nx generate @nx/js:library
. I'm not sure if this is still the command to create a libraryCreate a new react demo app using the Lit JS SDK
section that uses the command:yarn tools --create --react contracts-sdk --demo
. I'm not sure if this is still relevantDeleting a package or app
section. The following commands this section used are no longer in thepackage.json
:Deleting a package or app
Building Local Changes
section which included instruction on how to usenpm link
to test changes to a package locally. While this command seems useful, I didn't know if we still wanted to include it and if the instructions are accurate:Building Local Changes
During development you may wish to build your code changes in
packages/
in a client application to test the correctness of the functionality.If you would like to establish a dependency between packages within this monorepo and an external client application that consumes these packages:
npm link
at the root of the specific package you are making code changes in.npm link <package> --save
to ensure that thepackage.json
of the client application is updated with afile:
link to the dependency. This effectively creates a symlink in thenode_modules
of the client application to the local dependency in this repository.Having done this setup, this is what the development cycle looks like moving forward:
Publishing
section. I'm not sure if these are still the commands to publish the SDK:Publishing
You must have at least nodejs v18 to do this.
Install the latest packages with
yarn install
Run
yarn bump
to bump the versionBuild all the packages with
yarn build
Run the unit tests with
yarn test:unit
& e2e node testsyarn test:local
locally & ensure that they passUpdate the docs with
yarn gen:docs --push
Finally, publish with
yarn publish:packages
Commit these changes "Published version X.X.X"
Testing with a Local Lit Node
section. The commands used by this section no longer exist inpackage.json
:Testing with a Local Lit Node
First, deploy your Lit Node Contracts, since the correct addresses will be pulled from the
../lit-assets/blockchain/contracts/deployed-lit-node-contracts-temp.json
file.Set these two env vars:
Run:
To run manual tests:
ENV Vars
Dockerfile
section. This just had...coming soon
Interactive graph dependencies using NX
section. thegraph
command this section used no longer exists inpackage.json
FAQs & Common Errors
section. The section didn't actually seem useful anymore imo, and it didn't really answer any questions. Maybe theerror Command failed with exit code 13.
error is worth including?