Skip to content

CompatHelper: bump compat for DataStructures to 0.19, (keep existing compat) #959

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

github-actions[bot]
Copy link
Contributor

@github-actions github-actions bot commented Aug 1, 2025

This pull request changes the compat entry for the DataStructures package from 0.10, 0.11, 0.12, 0.13, 0.14, 0.17, 0.18 to 0.10, 0.11, 0.12, 0.13, 0.14, 0.17, 0.18, 0.19.
This keeps the compat entries for earlier versions.

Note: I have not tested your package with this new compat entry.
It is your responsibility to make sure that your package tests pass before you merge this pull request.

@kleinschmidt kleinschmidt force-pushed the compathelper/new_version/2025-08-01-07-43-45-208-03119644977 branch from 7f37642 to 2d2bfcb Compare August 1, 2025 07:43
@nalimilan nalimilan mentioned this pull request Aug 1, 2025
@andreasnoack
Copy link
Member

JuliaCollections/SortingAlgorithms.jl#101 is blocking on pre but I don't understand the error on the other versions.

@devmotion
Copy link
Member

I assume the problem is that the force_latest_compatible_version=true setting in Pkg that the julia-runtest action uses for CompatHelper PRs (to enforce that the updated dependency is actually tested) tries to enforce the use of JET 0.10. However, while seemingly JET 0.10 is the latest "compatible" version allowed in the Project.toml file, actually on Julia < 1.12 JET 0.9 is the latest compatible version since JET 0.10 only supports Julia >= 1.12.

So I suspect this is an upstream issue of the implementation of force_latest_compatible_version in Pkg, most likely it does not take into account the julia compatibility when enforcing latest compatible versions.

The simple workaround for the time being: Reopen separate non-CompatHelper PRs with the version update...

@devmotion
Copy link
Member

@DilumAluthge are you aware of this issue with force_latest_compatible_version? Do you think Resolver.jl could help with this issue (apparently the downgrade action was already changed to using it and there's some draft PR in Pkg)?

@DilumAluthge
Copy link
Contributor

Yeah, force_latest_compatible_version will force the latest version that is compatible with the package compat entry; there's no logic to relax that restriction if the latest version is not compatible with older Julia versions.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants